search

JakeWharton / RxBinding

RxJava binding APIs for Android's UI widgets.
Apache License 2.0
9.68k stars 971 forks source link

Dispose of SeekBarChangeObservable #419

Closed RicardoBelchior closed 6 years ago

RicardoBelchior commented 6 years ago

https://github.com/JakeWharton/RxBinding/blob/24b73f4d2f929cc732d1e7b64e6b900241fb2205/rxbinding/src/main/java/com/jakewharton/rxbinding2/widget/SeekBarChangeObservable.java#L58

I'm just curious, why is SeekBarChangeObservable.Listener#onDispose setting the listener once again?

Instead of: view.setOnSeekBarChangeListener(this); Shouldn't it be view.setOnSeekBarChangeListener(null); ?

JakeWharton commented 6 years ago

Yep! Send a PR?

On Fri, Nov 24, 2017, 2:42 PM Ricardo Belchior notifications@github.com wrote:

https://github.com/JakeWharton/RxBinding/blob/24b73f4d2f929cc732d1e7b64e6b900241fb2205/rxbinding/src/main/java/com/jakewharton/rxbinding2/widget/SeekBarChangeObservable.java#L58

I'm just curious, why is SeekBarChangeObservable.Listener#onDispose setting the listener once again?

Instead of: view.setOnSeekBarChangeListener(this); Shouldn't it be view.setOnSeekBarChangeListener(null); ?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/JakeWharton/RxBinding/issues/419, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEEEYKDAqwSTyOH6PAJQGsmcpxt3-0pks5s5xwsgaJpZM4QqJGv .

RicardoBelchior commented 6 years ago

ok