search

JakeWharton / RxBinding

RxJava binding APIs for Android's UI widgets.
Apache License 2.0
9.68k stars 971 forks source link

RxJava 3 support #531

Closed BraisGabin closed 4 years ago

BraisGabin commented 5 years ago

It would be great to have support to RxJava3

JakeWharton commented 5 years ago

At the very least, I don't want to do any conversion until a 3.0 final is released. I do not want to maintain two versions.

BraisGabin commented 5 years ago

And what about a SNAPSHOT? To make it easier to test RxJava3 meanwhile the API is not freezed?

JakeWharton commented 4 years ago

A snapshot comes with the same problem because it still requires the source to be maintained twice. For example, if we had done this and the ViewPager2 stuff landed last week how would it get migrated to 3? I'm not ready to maintain two versions until 3.0 is much closer to release, and even then I'm not excited about the prospect as the value proposition of 3.0 is extremely low to the point where it feels like it's actually harming the Rx ecosystem.

On Tue, Oct 29, 2019 at 7:15 AM Brais Gabín notifications@github.com wrote:

And what about a SNAPSHOT? To make it easier to test RxJava3 meanwhile the API is not freezed?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/JakeWharton/RxBinding/issues/531?email_source=notifications&email_token=AAAQIEIBUKTLAOWJHQZZUQDQRALM5A5CNFSM4JFSJRL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECQDUUA#issuecomment-547371600, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAQIEMDKHF4W53YZUT5WRDQRALM5ANCNFSM4JFSJRLQ .

hborders commented 4 years ago

RxJava 3 has been released. :)

sacrificium-dev commented 4 years ago

Any news here?

The binding-library is great and we use it excessively. During the migration to RxJava3 I figured out, that it does not support the RxJava3 dependencies, or am I wrong?

For example a call to the following still returns an io.reactivex.Observable instead of io.reactivex.rxjava3.core.Observable:

onReadingChangedObservable = RxTextView.textChanges(myEditText)
                .subscribeOn(io.reactivex.rxjava3.android.schedulers.AndroidSchedulers.mainThread())

So it's not compatible with the rest of my RxJava3-code and stopped me from migration to RxJava3 for now...

BraisGabin commented 4 years ago

You can use https://github.com/akarnokd/RxJavaBridge meanwhile (if it's worth it the intermediate step)