View source link includes URL fragment

JakeWharton / SdkSearch

An Android app and Chrome extension for searching the Android SDK documentation.

Apache License 2.0

2.06k stars 176 forks source link

View source link includes URL fragment #114

Closed hongrich closed 6 years ago

hongrich commented 6 years ago

The Chrome extension adds a 'view source' link to the class reference pages, but it doesn't seem to be stripping out URL fragments (and maybe other URL components as well?).

Navigate to https://developer.android.com/reference/android/widget/Toolbar#collapseActionView()
'view source' links to https://android.googlesource.com/platform/frameworks/base/+/refs/heads/master/core/java/android/widget/Toolbar#collapseActionView().java
'view source' should link to https://android.googlesource.com/platform/frameworks/base/+/refs/heads/master/core/java/android/widget/Toolbar.java

JakeWharton commented 6 years ago

Apparently node.js doesn't let me use URL without require('url') which you don't need when running in a browser. As a result I've spent 100x longer trying to get the tests working than fixing the bug and writing the tests. Ugh. 🤦‍♂️