search

JakeWharton / SdkSearch

An Android app and Chrome extension for searching the Android SDK documentation.
Apache License 2.0
2.06k stars 176 forks source link

Close the app when back is pressed with keyboard opened and search field is empty #133

Open bernaferrari opened 6 years ago

bernaferrari commented 6 years ago

I'm not sure how SDK Search is going to be in the future, but right now, I think it makes sense to kill the app when user press back, the keyboard is opened and the search field is empty. If the back is pressed, the user probably wants to exit the app, since there is no addional functionality.

There are apps like Chrome that already do this to some extent, for example, by automatically closing the omnibox fragment when user press back and the keyboard is opened.

JakeWharton commented 5 years ago

Sounds good. PR welcome for this.

mohammaddvi commented 4 years ago

Hi, can i work on this issue?Is it open yet?

JakeWharton commented 4 years ago

Go for it

On Wed, Mar 11, 2020, at 3:08 PM, Mohammad wrote:

Hi, can i work on this issue?Is it open yet?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/JakeWharton/SdkSearch/issues/133#issuecomment-597815424, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAQIEJN5UZSFSDBG323ADLRG7ORPANCNFSM4FYUH3HA.

mohammaddvi commented 4 years ago

Hi again, After some thinking about this enhancement I find out this is a bad UX and detecting keyboard visibility is some boilerplate code that not necessary. If you are not agree let me know to implement this enhancement.

dfresh806 commented 4 years ago

Ok

On Fri, Mar 13, 2020, 9:02 AM Mohammad notifications@github.com wrote:

Hi again, After some thinking about this enhancement I find out this is a bad UX and detecting keyboard visibility is some boilerplate code that not necessary. If you are not agree let me know to implement this enhancement.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/JakeWharton/SdkSearch/issues/133#issuecomment-598734673, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOWHHTZIKWSAI5UUU7R2K4LRHI4GJANCNFSM4FYUH3HA .