[dagger-reflect] Add tests for Reflection utilities

JakeWharton / SdkSearch

An Android app and Chrome extension for searching the Android SDK documentation.

Apache License 2.0

2.06k stars 176 forks source link

[dagger-reflect] Add tests for Reflection utilities #140

Closed TWiStErRob closed 5 years ago

TWiStErRob commented 5 years ago

Question: Is there any reason why you used (field.getModifiers() & Modifier.PUBLIC) == 0 instead of ! java.lang.reflect.Modifier.isPublic(field.getModifiers()) ?

e.g. https://github.com/JakeWharton/SdkSearch/blob/3351cad9bfacb0a364858e843774147143f58c7a/dagger-reflect/reflect/src/main/java/dagger/reflect/Reflection.java#L57-L60

this questions also stands for ReflectiveMembersInjector

JakeWharton commented 5 years ago

I don't think these need explicitly tested. They're implementation details which provide behavior to the library which is what should be tested. If these are broken, they should be tested through the normal Dagger interaction that the library is meant to provide. Or, if they're broken but in a way that can never be triggered by a Dagger interaction I don't think it really matters.