JakeWharton / Telecine

Record full-resolution video on your Android devices.
Apache License 2.0
2.47k stars 460 forks source link

Quick tile #114

Closed mattprecious closed 8 years ago

mattprecious commented 8 years ago

So can't merge this yet for obvious preview-related reasons. Also, as you're already aware, targeting SDK 23+ means storage and draw-over-apps permissions aren't granted automatically. Opening the PR now anyway so there's no duplicate efforts.

Closes #92.

JakeWharton commented 8 years ago

draw-over-apps permissions [isn't] granted automatically

This is only true of Android 6.0.0 but not 6.0.1+. I guess I'll need to design something for 6.0.0 where we tell you to go to Settings and enable it. Ugh.

mattprecious commented 8 years ago

Seems to be true again on N... This was crashing for me until I turned on the permission manually.

JakeWharton commented 8 years ago

Ah, yeah. The OS restriction is still there. The Play Store automatically grants the permission when you install through it.

mattprecious commented 8 years ago

Ah, right. Cool! One less issue to tackle.

jaredsburrows commented 8 years ago

👍

JakeWharton commented 8 years ago

@mattprecious update to 24 proper at your convenience. let's get this shipped!

mattprecious commented 8 years ago

Done. Targeting 24 means we have to ask for permissions.

JakeWharton commented 8 years ago

I may have asked this before, but do we need to target 24 for this? Or is compile 24 all that's needed?

jaredsburrows commented 8 years ago

Leave the target the same. On Jun 15, 2016 1:19 PM, "Jake Wharton" notifications@github.com wrote:

I may have asked this before, but do we need to target 24 for this? Or is compile 24 all that's needed?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/JakeWharton/Telecine/pull/114#issuecomment-226307485, or mute the thread https://github.com/notifications/unsubscribe/ABqMSFsc0T-wDLjrxuTlI7vndrAcJ24-ks5qMF5SgaJpZM4Itoyp .

mattprecious commented 8 years ago

Wasn't needed. 22 works fine.

jaredsburrows commented 8 years ago

Yes. On Jun 15, 2016 1:25 PM, "Matthew Precious" notifications@github.com wrote:

Wasn't needed. 22 works fine.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/JakeWharton/Telecine/pull/114#issuecomment-226309180, or mute the thread https://github.com/notifications/unsubscribe/ABqMSP7C2X2ME-slM4KsJoycFkbKriP2ks5qMF_GgaJpZM4Itoyp .

jaredsburrows commented 8 years ago

@mattprecious Your PR is still failing:

* What went wrong:
A problem occurred configuring project ':telecine'.
> failed to find target with hash string 'android-24' in: /usr/local/android-sdk

Update the TravisCI with this one:

language: android

jdk:
 - oraclejdk7
 - oraclejdk8

android:
  components:
    - tools
    - platform-tools
    - build-tools-24.0.0
    - android-24
    - extra-android-m2repository
    - extra-google-m2repository

script:
  - ./gradlew clean check -Dpre-dex=false

branches:
  except:
    - gh-pages

notifications:
  email: false

sudo: false

cache:
  directories:
    - $HOME/.gradle
mattprecious commented 8 years ago

Can't use JDK 7 anymore, apparently.

mattprecious commented 8 years ago

It's also yelling because the platform tools are too old. Is there a way to force travis to update?

jaredsburrows commented 8 years ago

@JakeWharton has not responded to my PR here(https://github.com/JakeWharton/Telecine/pull/115) but my suggestion for this repo would be to "ignore" jdk7. See here:https://github.com/JakeWharton/Telecine/pull/115/files#diff-354f30a63fb0907d4ad57269548329e3R7.

jaredsburrows commented 8 years ago

@mattprecious See here: The platforms tools are still in "preview" but there is a 24 RC1. The latest release is still 23.1. :(

screen shot 2016-06-15 at 4 21 25 pm
JakeWharton commented 8 years ago

No the latest is 24. You just can't install it from the standalone SDK manager.

IDGAF about JDK 7. It's EOL anyway.

On Thu, Jun 16, 2016 at 11:59 AM Jared Burrows notifications@github.com wrote:

@mattprecious https://github.com/mattprecious See here: The platforms tools are still in "preview" but there is a 24 RC1. The latest release is still 23.1. :( [image: screen shot 2016-06-15 at 4 21 25 pm] https://cloud.githubusercontent.com/assets/1739848/16123620/8e4888f8-33a0-11e6-9a49-dbccffc46c51.png

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/JakeWharton/Telecine/pull/114#issuecomment-226530838, or mute the thread https://github.com/notifications/unsubscribe/AAEEESoXdoxkK8NFe2gpoX-emDHTSC-Cks5qMXLhgaJpZM4Itoyp .

jaredsburrows commented 8 years ago

@JakeWharton I'll update my PR as well.

JakeWharton commented 8 years ago

This is blocked by 2.2.0 being released then which can update the SDK automatically for v24 of tools (and everything else).

On Thu, Jun 16, 2016 at 12:02 PM Jared Burrows notifications@github.com wrote:

@JakeWharton https://github.com/JakeWharton I'll update my PR as well.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/JakeWharton/Telecine/pull/114#issuecomment-226531616, or mute the thread https://github.com/notifications/unsubscribe/AAEEEf2ec-BgM5anr9psoLAMjF10KaYCks5qMXN6gaJpZM4Itoyp .

jaredsburrows commented 8 years ago

@mattprecious Try this build again. Platform tools 24 is out. I am doing it here: https://github.com/jaredsburrows/android-gradle-java-app-template/blob/master/.travis.yml.

JakeWharton commented 8 years ago

You spelled launch "Lauch".

screenshot_20160619-025528

mattprecious commented 8 years ago

Just saving bytes.

jaredsburrows commented 8 years ago

@mattprecious Lol. Make a quick PR to fix?

mattprecious commented 8 years ago

It's already fixed. I believe Jake updated my branch before merging.