search

JakeWharton / Telecine

Record full-resolution video on your Android devices.
Apache License 2.0
2.47k stars 460 forks source link

Add Demo Mode #144

Closed NightlyNexus closed 7 years ago

NightlyNexus commented 7 years ago

The option to enable Demo Mode will only be visible after the app is granted the DUMP permission. The permission can be granted via pm.

There is a split second display delay before the SystemUI updates from the broadcast. Maybe there's a better spot to send the broadcasts before RecordingSession.Listener.onStart()?

Also, of course, just close this if there's not a large use case relative to the code addition. :)

JakeWharton commented 7 years ago

There is a split second display delay before the SystemUI updates from the broadcast. Maybe there's a better spot to send the broadcasts before RecordingSession.Listener.onStart()

We could add an .onPrepare() callback triggered when the "Recording..." item is shown and starts to fade out.

NightlyNexus commented 7 years ago

Oh, I like that idea; I'll give it a shot in a bit!

JakeWharton commented 7 years ago

Lint is still failing for some reason despite you suppressing it.

NightlyNexus commented 7 years ago

Yeah, I was just about to look at that. Hmm. Wonder if it's an accidental difference between RequiresApi and TargetApi.

On Sat, Jan 14, 2017, 10:22 PM Jake Wharton notifications@github.com wrote:

Lint is still failing for some reason despite you suppressing it.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/JakeWharton/Telecine/pull/144#issuecomment-272676660, or mute the thread https://github.com/notifications/unsubscribe-auth/AD2Im0gtW-WQH953eHmJscNrgv1zz4oLks5rSbsrgaJpZM4Lj0Ph .

NightlyNexus commented 7 years ago

I don't see why Lint is failing. Should I file a bug and work around it here?

JakeWharton commented 7 years ago

Does it fail locally as well?

On Sun, Jan 15, 2017 at 2:09 PM Eric Cochran notifications@github.com wrote:

I don't see why Lint is failing. Should I file a bug and work around it here?

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/JakeWharton/Telecine/pull/144#issuecomment-272729862, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEEEYx7rVGmW999EK1PwSz6vQXWBRbbks5rSpkGgaJpZM4Lj0Ph .

NightlyNexus commented 7 years ago

Yeah, running lint fails on my machine with the same errors.

On Sun, Jan 15, 2017, 2:14 PM Jake Wharton notifications@github.com wrote:

Does it fail locally as well?

On Sun, Jan 15, 2017 at 2:09 PM Eric Cochran notifications@github.com wrote:

I don't see why Lint is failing. Should I file a bug and work around it here?

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub <https://github.com/JakeWharton/Telecine/pull/144#issuecomment-272729862 , or mute the thread < https://github.com/notifications/unsubscribe-auth/AAEEEYx7rVGmW999EK1PwSz6vQXWBRbbks5rSpkGgaJpZM4Lj0Ph

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/JakeWharton/Telecine/pull/144#issuecomment-272732405, or mute the thread https://github.com/notifications/unsubscribe-auth/AD2Im70rAF_pEws2OtnrdY-P9yMsYaVmks5rSppEgaJpZM4Lj0Ph .