Still video remains black

JakeWharton / Telecine

Record full-resolution video on your Android devices.

Apache License 2.0

2.47k stars 460 forks source link

Still video remains black #35

Open SimonMarquis opened 9 years ago

SimonMarquis commented 9 years ago

Steps to reproduce:

Launch the overlay
Start the recording
Wait a few seconds without doing anything
Stop the recording

Results: The video remains black.

It seems there is no key frame in the video...

JakeWharton commented 9 years ago

I don't see quite exactly this behavior. I get a single-frame video of the content regardless of how long I wait.

SimonMarquis commented 9 years ago

It seems to be more a decoding issue. Playing the file with vlc (mobile & desktop) renders a black image. Playing from the Google+ photos website (youtube) renders the correct image but with some glitches. Playing from the mobile Google+ Photos app renders the video correctly...

Some players might just ignore the first keyframe?

JakeWharton commented 9 years ago

I think it's probably a result of the recording not working correctly, as your original issue stated. And then what you are seeing is simply a result of the incorrect recording being handled differently by different players.

On Mon Feb 16 2015 at 12:35:38 AM Simon Marquis notifications@github.com wrote:

It seems to be more a decoding issue. Playing the file with vlc (mobile & desktop) renders a black image. Playing from the Google+ photos website (youtube) renders the correct image but with some glitches. Playing from the mobile Google+ Photos app renders the video correctly...

Some players might just ignore the first keyframe?

— Reply to this email directly or view it on GitHub https://github.com/JakeWharton/Telecine/issues/35#issuecomment-74474387.

SimonMarquis commented 9 years ago

Seems legit. While reading the code, I was wondering if starting the recorder before create the VirtualDisplay would help? here

JakeWharton commented 9 years ago

Yeah. Certainly worth a shot.

On Mon Feb 16 2015 at 12:41:24 AM Simon Marquis notifications@github.com wrote:

Seems legit. While reading the code, I was wondering if starting the recorder before create the VirtualDisplay would help? here https://github.com/JakeWharton/Telecine/blob/04811c597926939af46db3b97625f550bdd5a1e2/telecine/src/main/java/com/jakewharton/telecine/RecordingSession.java#L186

— Reply to this email directly or view it on GitHub https://github.com/JakeWharton/Telecine/issues/35#issuecomment-74474931.

SimonMarquis commented 9 years ago

Unfortunately, it doesn't fix anything...

JakeWharton commented 9 years ago

I tried all kinds of things last night to no effect.

jaredsburrows commented 9 years ago

@SimonMarquis What device? Obviously you are running Android 5.0+.

jaredsburrows commented 9 years ago

@SimonMarquis ?