search

JakeWharton / ThreeTenABP

An adaptation of the JSR-310 backport for Android.
Apache License 2.0
3.55k stars 133 forks source link

Do I actually want to switch to desugared native apis? #127

Closed ursusursus closed 4 years ago

ursusursus commented 4 years ago

Hi, I see the note in the readme as to switch to the native apis via L8

However, timezone data is now baked into the os, right?

Do I want that?

JakeWharton commented 4 years ago

https://source.android.com/devices/tech/config/timezone-rules

JakeWharton commented 4 years ago

Timezone data updates out-of-band with the OS.

ursusursus commented 4 years ago

Hold on, isnt that 8.1+?

JakeWharton commented 4 years ago

Yes. If you want to bundle your own timezone data you are still free to. The process of installing them is exactly the same as the mechanism this library uses.

ursusursus commented 4 years ago

Would you recommend doing that? Not sure if it is cool to leave say Android 5' with its platform tz data if I were to simply swap imports to java.time

JakeWharton commented 4 years ago

I mean ultimately those TZ rules are going to be what's used by Date and Calendar and the OS itself, so there's local consistency. I think it's a trade-off that you have to decide on.

Ultimately I'm going to publish updates to the tzdb in this project for as long as it's easy. So not switching is also an option.

ursusursus commented 4 years ago

Right, guess I'll stay until minSdk 26 is a thing, not much reason to switch. Thanks