Question: Where's the code exactly?

[AndroidDeveloperLB]

It is said this library is better than ThreeTenBP repo, here .

So I was curious and looked at the repo's files, but I don't see a lot at all, especially not of LocalDate, which I somehow use by using this repo.

How could it be?

Is it somehow using the threetenbp library, yet with some changes applied?

If so, is it frequently updated like it? Maybe even auto-updated ? I ask this because I notice that the threetenbp library seems updated more recently (has some files updated 6 months ago), yet here it's not (newest files updated 11 months ago) .

[JakeWharton]

The code is from ThreeTenBP. This library merely repackages the timezone database.

https://github.com/JakeWharton/ThreeTenABP/blob/5bf6fe3c7940297d05e71726ae8a2b8919792ca3/threetenabp/build.gradle#L4

[AndroidDeveloperLB]

Latest version is 1.3.6 , no? How does it do the re-packaging? It overrides some classes/functions somehow? The goal is to avoid jar file, as the description says: "JAR resource for loading timezone information" ?

[JakeWharton]

The timezone DB is in the assets folder of this libarry.

On Wed, Jan 3, 2018 at 10:40 AM AndroidDeveloperLB notifications@github.com wrote:

Latest version is 1.3.6 , no? How does it do the re-packaging? The goal is to avoid jar file, as the description says: "JAR resource for loading timezone information" ?

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/JakeWharton/ThreeTenABP/issues/66#issuecomment-355043232, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEEERW61-1q1jw29bYir2eLeqEywMP4ks5tG59mgaJpZM4RR1lx .

[AndroidDeveloperLB]

Nice. But what about the version? Shouldn't it be 1.3.6 ? Also, I think that since this repo is based on the other one, maybe use the same exact version numbers?

[JakeWharton]

You're free to depend on a newer version of threetenbp directly if you require its updates. This library won't be updating the version for every threetenbp release.

On Wed, Jan 3, 2018 at 10:53 AM AndroidDeveloperLB notifications@github.com wrote:

Nice. But what about the version? Shouldn't it be 1.3.6 ? Also, I think that since this repo is based on the other one, maybe use the same exact version numbers?

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/JakeWharton/ThreeTenABP/issues/66#issuecomment-355046696, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEEEb0BslDuEVPLk_SmGwXVVlmgaomMks5tG6JwgaJpZM4RR1lx .

[AndroidDeveloperLB]

Makes sense. I have no idea what's new there, so I don't know if it'll worth it. I just like most updated one, to avoid bugs, have better functions, and better performance...

Do you update your repo every now and then?

[JakeWharton]

Yep. Feel free to send a PR to update the version anytime there's a new one.

On Wed, Jan 3, 2018 at 10:57 AM AndroidDeveloperLB notifications@github.com wrote:

Makes sense. I have no idea what's new there, so I don't know if it'll worth it. I just like most updated one, to avoid bugs, have better functions, and better performance...

Do you update your repo every now and then?

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/JakeWharton/ThreeTenABP/issues/66#issuecomment-355047799, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEEEaavMPeqUoxBceap1W0aZM-_Zrpxks5tG6NOgaJpZM4RR1lx .

[AndroidDeveloperLB]

ok here: https://github.com/JakeWharton/ThreeTenABP/pull/70

repo here: https://github.com/AndroidDeveloperLB/ThreeTenABP

[AndroidDeveloperLB]

It could be nice if you also update the version of your repo, to be identical to the one it's based on.