search

JakeWharton / butterknife

Bind Android views and callbacks to fields and methods.
http://jakewharton.github.io/butterknife/
Apache License 2.0
25.55k stars 4.6k forks source link

@OnTextChanged can be optimize if there are two id's used on function. #1242

Open Sathawale27 opened 6 years ago

Sathawale27 commented 6 years ago

When we use @OnTextChanged annotation on function with more than two id's as value, then generated code contains separate TextWatcher for each view and passes separately to the views addTextChangedListener. I don't know the solution for this optimization, but if it is possible i will give it a try.

JakeWharton commented 6 years ago

Seems like the solution is to create the listener as a local and then pass it to every view. This optimization would work for any listener.

ghost commented 6 years ago

@JakeWharton can I work on this?

JakeWharton commented 6 years ago

Go for it

On Thu, Sep 13, 2018 at 2:52 PM MONIKA-KUMAR-JETHANI < notifications@github.com> wrote:

@JakeWharton https://github.com/JakeWharton can I work on this?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/JakeWharton/butterknife/issues/1242#issuecomment-421113567, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEEEYcSiw9oGcWpUsfCyT7XzwqJ4lM5ks5uaqlsgaJpZM4TLHwZ .