search

JakeWharton / flip-tables

Because pretty-printing text tables in Java should be easy.
Apache License 2.0
633 stars 70 forks source link

Column length is not correctly calculated if the strings contain ANSI color escape codes. #9

Closed metabrain closed 6 years ago

metabrain commented 9 years ago

Since they don't actually take space on the screen, it causes the String::length to mismatch the size the String takes up on the screen which causes severe misalignment issues.

I wouldn't mind to fix this on the weekend and submit a pull request, should be an easy fix.

JakeWharton commented 9 years ago

Please do! That would be great.

On Thu, Sep 17, 2015, 12:24 PM Daniel Parreira notifications@github.com wrote:

Since they don't actually take space on the screen, it causes the String::length to mismatch the size the String takes up on the screen.

I wouldn't mind to fix this on the weekend and submit a pull request, should be an easy fix.

— Reply to this email directly or view it on GitHub https://github.com/JakeWharton/flip-tables/issues/9.

metabrain commented 9 years ago

No worries, cheers!

metabrain commented 8 years ago

I'll try to pick it up this weekend (4 months later... hahaha)