JakeWharton / jakewharton.com

Personal website and blog.
http://jakewharton.com
Apache License 2.0
119 stars 24 forks source link

Gradle best practices in KMP Compose post #49

Open TWiStErRob opened 2 years ago

TWiStErRob commented 2 years ago

https://jakewharton.com/multiplatform-compose-and-gradle-module-metadata-abuse/

https://github.com/JakeWharton/jakewharton.com/blame/gh-pages/_posts/2021-11-04-multiplatform-compose-and-gradle-module-metadata-abuse.md#L199

I noticed that in

tasks.named("generateMetadataFileForKotlinMultiplatformPublication").configure

you didn't declare the 4 implicit inputs to the task. This might cause up to date issues if the version changes or the text files change. I'm almost certain that in your real project you actually did do that, but ommited those 4 lines for brevity. If that's the case, would you add those in, just because people might copy-paste this as coming from a "authorative source" and introduce problems in their own builds.

Happy to PR if you accept the suggestion.