Decode from stream instead of string

JakeWharton / retrofit2-kotlinx-serialization-converter

A Retrofit 2 Converter.Factory for Kotlin serialization.

Apache License 2.0

1.04k stars 62 forks source link

Decode from stream instead of string #43

Open VincentJoshuaET opened 3 years ago

VincentJoshuaET commented 3 years ago

class FromString(override val format: StringFormat) : Serializer() {
    override fun <T> fromResponseBody(loader: DeserializationStrategy<T>, body: ResponseBody): T {
      val string = body.string()
      return format.decodeFromString(loader, string)
    }

    override fun <T> toRequestBody(contentType: MediaType, saver: SerializationStrategy<T>, value: T): RequestBody {
      val string = format.encodeToString(saver, value)
      return RequestBody.create(contentType, string)
    }
  }

class FromStream(override val format: StringFormat) : Serializer() {
    override fun <T> fromResponseBody(loader: DeserializationStrategy<T>, body: ResponseBody): T {
      val stream = body.byteStream()
      return format.decodeFromStream(loader, stream)
    }

    override fun <T> toRequestBody(contentType: MediaType, saver: SerializationStrategy<T>, value: T): RequestBody {
      val stream = ByteArrayOutputStream()
      format.encodeToStream(saver, value, stream)
      return RequestBody.create(contentType, stream.toByteArray())
    }
  }

JakeWharton commented 3 years ago

I don't see much reason to change the encoding since both end up buffering. We can switch the decoding, however. Want to send a PR?

JakeWharton commented 3 years ago

This is blocked on:

[ ] Streaming being available for all format types, not just a single one
[ ] The streaming API being stable

FunkyMuse commented 2 years ago

This is blocked on:

* [ ]  Streaming being available for all format types, not just a single one

* [ ]  The streaming API being stable

Is there any update on this or where can we track this?