Sqaush view/level queue into one queue

JakeWharton / scalpel

A surgical debugging tool to uncover the layers under your app.

Apache License 2.0

2.77k stars 232 forks source link

Sqaush view/level queue into one queue #6

Closed emilsjolander closed 10 years ago

emilsjolander commented 10 years ago

Saw the todo in in code and thought i would fix it. I changed the naming from 'level' to 'layer' mostly because i thought is made it clearer but if you don't think it's appropriate i will revert that. Otherwise nothing much to say, this shouldn't take noticeably more memory as the previous version was boxing the level into a Integer. However if memory / allocation time would ever become a problem is't easy to start caching the LayeredView objects.

JakeWharton commented 10 years ago

Can you make the fields final?

JakeWharton commented 10 years ago

Also, super nit: spaces around the plus sign.

On mobile so can't comment on the actual line numbers.

JakeWharton commented 10 years ago

Made the changes myself.

JakeWharton commented 10 years ago

Thanks!

emilsjolander commented 10 years ago

Great, thx!