search

JakeWharton / timber

A logger with a small, extensible API which provides utility on top of Android's normal Log class.
https://jakewharton.github.io/timber/docs/5.x/
Apache License 2.0
10.41k stars 959 forks source link

Tag length limit was removed in API 26 not API 24 #426

Closed eygraber closed 3 years ago

eygraber commented 3 years ago

The lint check is fixed by https://github.com/JakeWharton/timber/pull/421/

eygraber commented 3 years ago

@JakeWharton it doesn't look like this fix was added to #421 (unless I'm missing something)

JakeWharton commented 3 years ago

https://github.com/JakeWharton/timber/pull/421/files#diff-f9022f20a262cea67e7cf0483894555f4a63dbb8e41993429e3599d128e78f29R148

JakeWharton commented 3 years ago

I was actually going to comment that it's best to separate fixes from behavior changes in the future because I almost missed it.

eygraber commented 3 years ago

That was just the lint check. This PR addresses the issue in Timber itself.

JakeWharton commented 3 years ago

Ah I thought this was an issue.