search

JakeWharton / timber

A logger with a small, extensible API which provides utility on top of Android's normal Log class.
https://jakewharton.github.io/timber/docs/5.x/
Apache License 2.0
10.46k stars 962 forks source link

Make Tree:tag protected instead of internal #477

Closed MFlisar closed 5 months ago

MFlisar commented 2 years ago

In a custom tree it may make sense to adjust tags with tree specific data. In timber v4 this was easily possible, not in v5 it isn't anymore.

Is this project still active? If so, please make Tree::tag at least protected so that sub classes can access, it does not make much sense to hide it from a derived class imho.. and this limits functionality of sub tree currently...

https://github.com/JakeWharton/timber/blob/9954d94abbaea9d003243be5b69f8ae0ffc0c99d/timber/src/main/java/timber/log/Timber.kt#L25

YarikSOffice commented 1 year ago

Facing the same issue, could not intercept the tag field to filter more stack trace elements

inteist commented 1 year ago

You do realize this is an open source project, right? And this is one trivial change. It would take less time to create a pull request than to type that original issue LOOL :)

hannesa2 commented 5 months ago

You do realize this is an open source project, right? And this is one trivial change.

@inteist I guess people don't make even simple pull requests, when they are never merged. At least for me it's valid

MFlisar commented 5 months ago

You do realize this is an open source project, right? And this is one trivial change. It would take less time to create a pull request than to type that original issue LOOL :)

You are responding to a 2 year old question... The PR is not the problem, but as @hannesa2 said, Jack Wharten is not accepting pull requests and he states that he thinks his library is feature complete - just check the open PRs, they are unresponded and open for 6-7 years now... So I would say the correct way is to ask and then make a PR...

BTW, I've written my own implementation and do support optional timber support in my library so I don't need an update anymore.

Maybe it makes you happy that I close this issue, LOOL :), to say it with your words..

Side Note: A PR for this issue did exist for 1 year now without any effect...