DDL: Explicit Nullability and CREATE INDEX

JakeWheat / simple-sql-parser

SQL parser in Haskell

http://jakewheat.github.io/simple-sql-parser/latest

Other

82 stars 29 forks source link

DDL: Explicit Nullability and CREATE INDEX #28

Closed greyson closed 3 years ago

greyson commented 4 years ago

I just noticed the postgres documentation (section 5.3.2) states that the NULL constraint is non-standard. I don't feel confident adding it as a dialect option (yet) but neither do I typically like to rewrite committed history. Would you prefer this be removed by revert or rebase?

JakeWheat commented 4 years ago

Hi, it looks good. Can you add simple parse tests for the two added syntaxes (just a single trivial test for each one)? Then I will merge it and fix it up for the dialect handling, so no need for any reverting.

JakeWheat commented 3 years ago

Thanks, I added some tests and tweaked it to support schema qualified names for the table name