search

Jakllp / MyPet

This is not the main project - Please visit https://github.com/MyPetORG/MyPet
https://www.spigotmc.org/resources/mypet.12725/
GNU Lesser General Public License v3.0
14 stars 8 forks source link

Bugs when using petadmin and storage, others #41

Closed ehetteNandaYo closed 3 years ago

ehetteNandaYo commented 3 years ago

if you capture a baby pet, it gets converted to its adult version, when taking a pet out from the storage you an error.

taking pet from storage https://paste.gg/p/anonymous/0e79113952a3471f91dd43d3cdd68211/files/788f9d04451642c3a3ae563055c38051/raw

Petadmin commands dont work like exp clone...

petadmin clone https://paste.gg/p/anonymous/36eff224519b4015a676836bf3a58b75/files/91fe2486a640440db003c34f27913f24/raw

cant change modes pb normal pb agroo pb farm

Jakllp commented 3 years ago

Some of this (exp, taking it from storage) seems to be entity-specific (this entity has specific attributes?) Should all have same source - identified and probably already fixed locally

Modes: Check behaviorSkill.isModeUsable

Couldn't reproduce baby-capturing-problem yet

Jakllp commented 3 years ago

@ehetteNandaYo What baby-pet did you try to capture?

Jakllp commented 3 years ago

Fixed commands+storage in https://github.com/Jakllp/MyPet/commit/19c4b15203f171a98a6c6da99fd36deae6ee8625

Still waiting on info for baby-capture Still working on behavior

ehetteNandaYo commented 3 years ago

Some of this (exp, taking it from storage) seems to be entity-specific (this entity has specific attributes?)

fresh captured zombie, I will try other later when I try,

What baby-pet did you try to capture?

Also zombie

I noticed because i had a db with pets from 1.16.5 and when I called it it was adult zombie, so I tried to capture another and same result

Jakllp commented 3 years ago

Alright. I thibk I fixed the storage problem (will be in the next release)

I tried a baby pig and a baby chicken. Will look into zombies later

Jakllp commented 3 years ago

Note to self: Baby Zombie might be due to new baby-system as baby zombies are different to other baby entities (might also effect piglins?)

Jakllp commented 3 years ago

Fixed baby-zombies in https://github.com/Jakllp/MyPet/commit/e7d2e38c8c214e6a892a0be4e9bd319efd6b678a

Jakllp commented 3 years ago

Forgot that behavior was still a thing

Jakllp commented 3 years ago

Behavior does work - Is skilltree-dependent - this might have been the cause for it not working on your end (or there was a bug that is now somehow fixed. Who knows)

ehetteNandaYo commented 3 years ago

petadmin exp still doesnt work

I tried it, it looks like it works but it doesnt, it didnt add set or remove any exp, it always stays the same

image

if you try with a new pet it looks like this

image

Jakllp commented 3 years ago

@ehetteNandoYo I'm guessing you used these commands: /petadmin exp <PlayerName> 878 for first screenshot /petadmin exp <Playername> 0 for second screenshot

Or did you enter the command differently?

ehetteNandaYo commented 3 years ago

no, i was trying different numbers and all of them show the same result, I believe 878 is the exp the pet has at the moment, because a recently captured pet has 0

Jakllp commented 3 years ago

image I gotta admit - I'm confused

I tried reproducing this error but the command works as I'd expect it to work - But:

The only way I found to get this result is by doing: /petadmin exp <Playername> set <number> The plugin expects the operator (in this case set) behind the amount (so: /petadmin exp <Playername> <number> set) which I gotta admit is odd.

The system technically works but the syntax can be improved (which I will do)

ehetteNandaYo commented 3 years ago

Ahhhh I was doing set number not number set which works... that was the issue...

Jakllp commented 3 years ago

Glad we could work it out ^^