search

Jako / FileDownloadR

Display a list of downloadable files without revealing the file url.
https://jako.github.io/FileDownloadR/
GNU General Public License v2.0
1 stars 1 forks source link

Snippet FileDownloadLink: Default template doesn't work in MODX 3 #1

Closed halftrainedharry closed 1 year ago

halftrainedharry commented 1 year ago

The default template

https://github.com/Jako/FileDownloadR/blob/d0f81e6608a725f8964b87a3304a62ba8e3c2187/core/components/filedownloadr/src/Snippets/FileDownloadLinkSnippet.php#L44

doesn't get parsed correctly, because @CODE: (with the colon at the end) is not in the list of valid types:

https://github.com/Jako/FileDownloadR/blob/d0f81e6608a725f8964b87a3304a62ba8e3c2187/core/components/filedownloadr/src/Helper/Parse.php#L43-L48

Also, the availability of pdoTools is not detected correctly in MODX 3:

https://github.com/Jako/FileDownloadR/blob/d0f81e6608a725f8964b87a3304a62ba8e3c2187/core/components/filedownloadr/src/Helper/Parse.php#L90

Related topic in the MODX forum: https://community.modx.com/t/filedownloadr-3-0-0-snippet-filedownloadlink-isnt-working/6757

Jako commented 1 year ago

Thanks for posting the issue. It is fixed with 3.0.1.