Jako / Yass

Yet Another Session Saver in MODX Revolution
0 stars 0 forks source link

Conflict with Articles on MODX 2.2.12 #1

Open lapubell opened 10 years ago

lapubell commented 10 years ago

I'm currently running into an issue when someone uses the tag lister link from an Articles page. Is this caused by a URL rewrite that I can help debug? It's caused by the foreach loop on line 62 of yass.class.php. Here's the output of the modx error file:

[2014-06-10 14:14:46](ERROR @ /path/to/http/core/components/yass/model/yass/yass.class.php : 62) PHP warning: Invalid argument supplied for foreach()

Here's my Yass Call, which is in a chunk, which is included in a template.

[[!Yass? &disabledTpl=`yass.disabled` &enabledTpl=`yass.enabled` &keyName=`ageVerified` ]]
Jako commented 10 years ago

It could be the dot in template chunk name. Try to change the template chunk names from yass.xxx to yass_xxx.

lapubell commented 10 years ago

I just tried that and it didn't work.

The snippet is working great on all the other pages, it's just when I try to use the links generated by the taglister placeholder on articles resources. I believe that the article plugin is doing some URL rewriting, so maybe it could have something to do with that?

-Kurtis

On Tue, Jun 10, 2014 at 11:20 PM, Thomas Jakobi notifications@github.com wrote:

It could be the dot in template chunk name. Try to change the template chunk names from yass.xxx to yass_xxx.

— Reply to this email directly or view it on GitHub https://github.com/Jako/Yass/issues/1#issuecomment-45705994.

lapubell commented 10 years ago

another clue, when I add this to the class on line 63: die( var_export($allowedConfigs));

$allowedConfigs dumps "false" on all the pages that the system appears to be working correctly, and it still breaks without giving me any feedback on the pages with the taglister trying to work. same modx error message as well. this could have something to do with that glob() function on line 60?

-Kurtis

On Wed, Jun 11, 2014 at 7:56 AM, Kurtis kholsapple@gmail.com wrote:

I just tried that and it didn't work.

The snippet is working great on all the other pages, it's just when I try to use the links generated by the taglister placeholder on articles resources. I believe that the article plugin is doing some URL rewriting, so maybe it could have something to do with that?

-Kurtis

On Tue, Jun 10, 2014 at 11:20 PM, Thomas Jakobi notifications@github.com wrote:

It could be the dot in template chunk name. Try to change the template chunk names from yass.xxx to yass_xxx.

— Reply to this email directly or view it on GitHub https://github.com/Jako/Yass/issues/1#issuecomment-45705994.

lapubell commented 10 years ago

I have removed a custom plugin that was working on the event PageNotFound, and things seem to be working ok.

I guess we can ignore this bug, but it still seems interesting that this would throw an error whenever the URL would be rewritten.

Thanks.

Jako commented 10 years ago

Think you have found a bug.

lapubell commented 10 years ago

Cool. Just FYI, I'm noticing this bug is firing on plugins when the plugin has the action of OnPageNotFound and is trying to do some URL rewriting.