coveralls
commented
6 years ago Pull Request Test Coverage Report for Build 449
- 48 of 49 (97.96%) changed or added relevant lines in 5 files are covered.
- 5 unchanged lines in 1 file lost coverage.
- Overall coverage increased (+0.004%) to 97.501%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| astrality/requirements.py | 22 | 23 | 95.65% | ||
| <!-- | Total: | 48 | 49 | 97.96% | --> |
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| astrality/filewatcher.py | 5 | 97.06% | ||
| <!-- | Total: | 5 | --> |
| Totals | |
|---|---|
| Change from base Build 440: | 0.004% |
| Covered Lines: | 3785 |
| Relevant Lines: | 3882 |
sshashank124
The implementation deletes any module which does not satisfy this dependency after having parsed all the modules. This means that modules which depends on other non-existant modules will still import their context before being disabled.
Doing it this way made it much easier to implement, so I think I can stomach this small bug. You would not want to enable modules that will be disabled due to missing dependencies anyway, as it is used more as a tool to find and enable any modules which you are missing.