search

JakobGM / patito

A data modelling layer built on top of polars and pydantic
MIT License
252 stars 23 forks source link

fix: make all xfail `read_csv` tests pass #62

Closed lmmx closed 1 month ago

lmmx commented 4 months ago

I was looking at the CSV reading abilities of patito and wondering what had happened to the tests for them, and it looks like they got marked as 'xfail' (expected to fail) 2 years ago, but the code involved looks fine. I can only imagine these were drafted but not actually finished off, and just left in a state that made the test suite pass.

Branching from the recent changes made on main, and removing the xfail marker, I clarified the actual behaviour of the CSV reading, this gives a better starting point for discussing any changes to CSV reading being discussed in #54 and #55

thomasaarholt commented 1 month ago

Thank you for doing this! These all look good!