search

JakobJingleheimer / nodejs-loaders

A collection of loaders to facilitate a quick and easy local development and CI testing environment.
11 stars 3 forks source link

chore(monorepo): separate each loader into its own package #23

Closed JakobJingleheimer closed 2 weeks ago

JakobJingleheimer commented 2 months ago

closes #19

AugustinMauroy commented 3 weeks ago

Feedback

Is .npmignore still need ?

JakobJingleheimer commented 3 weeks ago
  • Use 22 in .nvmrc to use LTSpackages.

I added backport requests to module.findPackageJSON(). I'm not sure if those will happen immediately. It will be available in 23.2 though.

  • Update dep to just have @types/nodejs because we don't need specific

I don't understand—isn't that what I did? (The package is @types/node btw)

Is .npmignore still need ?

Yes, very much: That's what prevents dev files getting published.

JakobJingleheimer commented 3 weeks ago

@AugustinMauroy I added some commits on top of a WIP commit. I'll finish my WIP commit, then cherry-pick your stuff back on top, and then force-push.

AugustinMauroy commented 3 weeks ago

I don't understand—isn't that what I did? (The package is @types/node btw)

yup my bad I didn't see you remove it from sub packages

AugustinMauroy commented 3 weeks ago

I added backport requests to https://github.com/nodejs/node/pull/55412. I'm not sure if those will happen immediately. It will be available in 23.2 though.

is it mean loader will only work for 23.2 ??? (for example nodejs.org still on 20)

JakobJingleheimer commented 3 weeks ago

is it mean loader will only work for 23.2 ??? (for example nodejs.org still on 20)

For tsx loader, unfortunately yes (until node:module.findPackageJSON() gets backported, which may be right away). I can't think of another way to find esbuild.config. Would love another idea! (we can't use process.cwd()).

As-is, we can't release this change until findPackageJSON is released.

EDIT: I spoke with Antoine, and 23.2 is being prepared now, then it will be backported to 22.x and 20.x 2 weeks later. So let's target Mon, 25 November for the nodejs-loaders v2 release.

AugustinMauroy commented 2 weeks ago

WOW happy to see this happened !