JakobTischler / MoreRealisticDLCs

A lua/xml project that adds MoreRealistic to the Farming Simulator DLCs
8 stars 0 forks source link

Manure Spreader shows 110% full and not 100% full #20

Closed Satissis closed 10 years ago

Satissis commented 10 years ago

@quadural I added the Lindner Manure Spreader and it all works except that when filling it, it fills to 110% fill level and shows in red as overfilled. The manure multiplier is set to 1.1 so that's the 110% fill level, but I also tested it with the Bergmann M 1080 in your moreRealisticVehicle pack and the manure multiplier is set to 1.18 but when filled ingame it only shows as 100% filled. I have pushed the Lindner Manure Spreader so you can see the setup and what specializations it's using. Is it something to do with the this script or something im MR it self ?

Kind regards Satis

quadural commented 10 years ago

can you check if this is the "fuel tank" capacity taken into account with the "manure spreader" capacity ? => can you reach the "0%" fill level ?

Satissis commented 10 years ago

Just checked to be sure. Yeah I can reach the 0% fill level, so I'm guessing that it's not the fuel level that interferes with it then.

quadural commented 10 years ago

do you experience the same issue with all the "modules" of the unitrac ? (provided the "multiplier" is greater than 1 for the current filltype)

Satissis commented 10 years ago

No, It's only the Manure Spreader Module. The other 3 works fine even when the multiplier is greater than 1. So what the problem is, is a riddle for me.

quadural commented 10 years ago

what is the "specialization" list for this module ? compared to the "manure liquid module" ?

EDIT : I found it (mr_manureSpreader_mousecontrolled_l) maybe this has to do with the "extended sprayer" specialization ? (or the "planeMover")

just give another try by removing/commenting those specializations

Satissis commented 10 years ago

Will do that when I get home from work.

Satissis commented 10 years ago

Alright, After the latest test, it's definitely the "planeMover" spec that is doing it. the extended sprayer works find.

EDIT: Okay I did some test printe of the self.specializations with the tableShow function we have in Courseplay. It gave me a hint to what might be going on. It have a function called getAttachedTrailersFillLevelAndCapacity which only the Vehicle specialization normally have, so I'm guessing that it either appending, prepending or maybe overwriting that function in the planeMover. Further test print of the self table and a lots of looking through all the variable name and values I found one variable that I could not link to any of the default specializations, which is: self.orgCapacity with a value of 2883, which is the capacity I set in the vehicleDataLindner.xml Maybe we would have to set that to the capacity * multiplier instead of the self.capacity if it have the planeMover spec. I haven't tested this thou, since I'm not totally sure when I should set that and where for that matters.

quadural commented 10 years ago

ok. So, they are using a "variable" capacity too. in such case, since this is only for this DLC equipment, there is an easy fix : you just have to set the "mr multiplier" to 1 and the "default capacity" to what you want with the multiplier applied. No need to use the "realCapacityMultiplier" when there is only one filltype.

Example : if base trailer DIN volume = 2.3M3 and manure heap factor is 1.3, you can simply set the capacity to 2990 liters.

Satissis commented 10 years ago

Alright. Well as it's done now, the "realCapacityMultiplier" is set automatic by the MoreRealisticDLCs mod, so I'm guessing we need a variable to set to true if we don't wanna use the auto "realCapacityMultiplier" setup then ?

quadural commented 10 years ago

the "realCapacityMultiplier" should not be auto since this is something specific to each "container" and also, specific to the "plane shape" of this container. Should not be set by default, and then, we should be able to add one or more specific multiplier if needed.

Satissis commented 10 years ago

okay, so just out of curiosity, I'm guessing that if the multiplier is not set at all, it will set the multiplier to 1 by default then ?

quadural commented 10 years ago

correct. This is an "optionnal" parameter for more "realism" (especially for trailers to differentiate wheat from manure for example)

you can see some "french" example of trailers full of manure here : http://forum.grostracteurspassion.com/viewtopic.php?f=2&t=21971&start=60&hilit=en+ce+moment+dans+les+stabulations

of course, this is not possible to achieve the same "extra capacity" with wheat or barley or cereal : wheat is more "liquid" than manure

Satissis commented 10 years ago

yeah I get the point :) Actually never thought of it that way :) Anyway @JakobTischler is working on it.

quadural commented 10 years ago

this is the well known "heap factor" (industry, mining, loaders and so)

Satissis commented 10 years ago

Alright, got everything to work as intended to. Thanks for the help