JakobTischler / MoreRealisticDLCs

A lua/xml project that adds MoreRealistic to the Farming Simulator DLCs
8 stars 0 forks source link

Shop stuff #65

Closed JakobTischler closed 9 years ago

JakobTischler commented 10 years ago

I played around with the shop a little and created a banner which would be displayed for each converted vehicle. Just a little bit of a promotion gimmick ;) Wanted to hear your opinion... regular text (Converted for MoreRealistic with the MoreRealisticDLCs mod.) or the banner? Would be, like the text, in all languages.


English: result_en


German: result_de

quadural commented 10 years ago

The "banner" is more noticeable. Moreover, it does not "use" the text description space (in some case, the description is already at the bottom, and so, the "additionnal "mr text" spills off the area. So : banner in my opinion.

JakobTischler commented 10 years ago

Moreover, it does not "use" the text description space (in some case, the description is already at the bottom, and so, the "additionnal "mr text" spills off the area.

True, but as you can see on the pictures, the banner also takes up some space. So there's no real space won by this :) By the way, which vehicles are you talking about (which have the long shop description)?

quadural commented 10 years ago

sorry, this is the "spec" text area that can be too small. Especially in case of "promotion" => krone swadro, horsch titan, horsch maestro

JakobTischler commented 10 years ago

Right, I hadn't noticed it for those. But also keep in mind, it depends on the language. The "problem" with all of those that you mentioned is that the fillTypes are displayed, which often takes up 2 lines instead of 1. I'll post it in the corresponding testing issues.

Dhalj commented 10 years ago

I like the banner, it looks very nice, and makes it more clear that it is a MR vehicle,

Dhalj commented 10 years ago

English shop specs:

Tractors: all 4 lines, except Lindner Transporter, spreader and slurry module which have 5 lines Frontloaders: all 4 or less lines except Ursus frontloader shovel which has 5 lines Harvesters: All 4 or less lines excepth the 3 Case IH combines which all have 5 lines Tippers: Marshal QM/16 and Ursus T-610A1 both have 6 lines Cultivators: All cultivators have 5 lines Seeders: Horsch seeder has 7 lines, all the Vaderstad seeders have 6 lines Manure spreaders: All 6 lines Slurry tanks: Marshal has 6 lines, Kotte has 5 lines Windrowers: Krone 6 lines, Ursus 5 lines Baling Tech: Marshal trailer and Ursus wrapper 4 lines, Ursus Baler 6 lines, Ursus trailer 5 lines Misc: Horsch overloader 5 lines, Truck is 4 lines

So we have to change 6 or 7 lines into max 5 lines?

JakobTischler commented 10 years ago

Very nice, thank you.

So we have to change 6 or 7 lines into max 5 lines?

Ok, so there's total space for 6 lines. The last line will always be the upkeep, so effectively we have 5 lines for our stuff. If there are fruit types specified, those can take up two lines, so we'll have to check those especially.

@quadural: could you check those for the French version, please?

Satissis commented 10 years ago

I do also like the banner better, just as Dural said, it's more noticeable :)

quadural commented 10 years ago

only the horsch titan requires 2 lines for the fruit description in french (I only checked the Titanium DLC of course)

Grisu118 commented 10 years ago

The banner looks really nice :)

JakobTischler commented 10 years ago

Forgot to reference this issue from the commit (https://github.com/JakobTischler/MoreRealisticDLCs/commit/138f773ceb4e0bb3e8ae7c596190d6b508738dc6). I fixed the specs data for the problematic vehicles. At least in English and German they are ok now.

Also, the conversion author is now mentioned in the shop description.

Dhalj commented 10 years ago

Today I got a PM from Saty on FS-UK:

Correct translation to CZ laguage « Sent to: dj on: Today at 11:08:51 am »

Hello, correct translation to CZ language for MoreRealisticDLCs :

for "DLC_MRIZED" & shopBanner_cz.dds

Převedeno na MoreRealistic pomocí MoreRealisticDLCs modu.

for "STORE_SPECS_POWERREQUIRED"

Požadovaný výkon:

for "STORE_SPECS_WORKINGSPEED"

Pracovní rychlost: %s %s

for "STORE_SPECS_FRUITS"

Druhy plodin: %s

for "STORE_DESC_AUTHOR"

Do MoreRealistic převedl %s.

The rest is OK ...


I do not know this guy and I do not know why he sends this to me, but maybe it is usefull, so I just share it with you guys

quadural commented 10 years ago

already a "leak" ? anyway, good to see there are still some people wanting to help.

JakobTischler commented 10 years ago

Well, there you see the good side and the bad side in one single example. I hate that someone found it, but I appreciate that he provided corrections.

quadural commented 10 years ago

On my side, only one person ask me about this project, and I only tell him to wait for the first beta (no link, no file provided) But I see your "github" is public and that you have "followers". And so, this is not really a surprise.

JakobTischler commented 10 years ago

Yes, I figured that it would happen sooner or later. GitHub does provide private repositories, but not for free. And I don't see why I should pay extra for projects like this.

Satissis commented 10 years ago

yeah, it can't be avoided without private github, but I don't mind that much, since we are in our testing state and soon selected beta testers or maybe an release.

Dhalj commented 10 years ago

new message: Correct translation to CZ laguage « Sent to: dj on: Today at 09:03:05 pm »

Good work, yet a small error in modDesc.xml Line 14 move at line 45...