search

Jakski / asdf-janet

Janet plugin for asdf version manager
MIT License
6 stars 1 forks source link

Apple silicon support #1

Open TravonteD opened 2 years ago

TravonteD commented 2 years ago

Is your feature request related to a problem? Please describe.

The build script assumes that there is a labeled tar.gz for the architecture of the machine on the releases page in the janet project. Since one doesn't exist for mac-os arm this fails to download anything.

Describe the solution you'd like

When there is no pre-built tar, download the source code and build it from there.

Jakski commented 2 years ago

@TravonteD Please provide a command you use to install Janet and its output. asdf-janet shouldn't take into account host's architecture, because it downloads source code from https://github.com/janet-lang/janet/archive/* and compiles it on target machine. Releases are also downloaded as a source code archives based on repository tags. For example currently asdf install janet latest should take archive from https://github.com/janet-lang/janet/archive/v1.19.2.tar.gz.

TravonteD commented 2 years ago

Apologies for the the late reply, here is the raw output. 

* Downloading janet v1.19.2...
~/.asdf/downloads/janet/1.19.2 ~
~/.asdf/downloads/janet/1.19.2/jpm ~/.asdf/downloads/janet/1.19.2 ~
~/.asdf/downloads/janet/1.19.2 ~
~
asdf-janet: Expected /Users/traydennis/.asdf/installs/janet/1.19.2/bin/janet to be executable.
asdf-janet: An error ocurred while installing janet 1.19.2.

The issue seems to be that the binaries don't exist in the directory. Running make from within the directory produced the executables libraries etc. in the build directory.

Jakski commented 2 years ago

Judging from output Janet isn't even compiled for some reason. make isn't involved in build process. meson generates files for ninja instead https://github.com/Jakski/asdf-janet/blob/3eefdfa010c7846c4e8d14ce827b62d158654ec0/lib/utils.bash#L68 I've added continuous integration for latest MacOS(https://github.com/Jakski/asdf-janet/commit/3eefdfa010c7846c4e8d14ce827b62d158654ec0), but I couldn't replicate this issue in GitHub Actions. You can try installing dependencies brew install gcc ninja meson curl and then repeat installation with asdf. Unfortunately I don't own Apple Silicon and can't verify installation locally.

If someone's having the same issue with Apple Silicion and have some idea what can be wrong, then please share information in this issue.