search

Jaksuhn / Automaton

BSD 3-Clause "New" or "Revised" License
21 stars 25 forks source link

[Bug Report] Getting Too Attached not working at all #14

Closed leonelvin closed 3 months ago

leonelvin commented 4 months ago

Describe the bug The feature "Getting Too Attached" gets stuck when started.

To Reproduce

  1. Enable Getting Too Attached
  2. Click on Start Looping
  3. Error: Unable to continue. This gear requires overmelding.

Further Investigation In the function ConfirmMateriaDialog, it seems the if clause is checking the incorrect value. It uses

addon->AtkValues[50].Type != 0

The Type above returns String8 instead of the actual value - which indicates the current amount of melded materias. It should have used .Int instead.

I tried to clone the repo and tested locally. By changing it to .Int, it gets passed the error, but still stuck at the Melding Dialog. If clicking on the Meld button manually, it carries on attaching the materia and retrieving the materia then it gets stuck again with no items selected. If I continue to manually select the item AND the materia, the cycle will repeat and then get stuck.

StarkITA commented 3 months ago

The item must be in your inventory, not armoury chest :)

leonelvin commented 3 months ago

The item and the materia were both in the inventory. The code is clearly wrong, when you're comparing Type with 0 (Int) when its return type is a String. Basic programming. But I wrote a lua script to do it more efficiently anyway.

Jaksuhn commented 3 months ago

The code wasn't wrong, the atkvalues shifted, which I fixed.

leonelvin commented 3 months ago

Ah I see. So it was fixed then. The comment earlier was saying as if I were doing something wrong, rather the underlining code had an issue which was fixed :)