search

Jaksuhn / Automaton

BSD 3-Clause "New" or "Revised" License
12 stars 21 forks source link

[Bug Report] Auto Adjust Retainer Listings keeps getting stuck #17

Open ahernika opened 2 months ago

ahernika commented 2 months ago

Describe the bug The Auto Adjust Retainer Listings features keeps getting stuck on the "Please wait and try search again", while trying to load market board data. It remains in that state unless I close the ItemSearchResult window myself and click compare prices again. This repeats again there after as the feature goes down the RetainerList every few items.

To Reproduce Steps to reproduce the behavior:

  1. Open sell items on your inventory on the market.
  2. Click on selected item.
  3. It gets stuck. there after unless I manually close search results and click compare prices option.

Expected behavior I was hoping the feature would go over each item automatically while readjusting the price instead me having to press on them manually every few items along the list.

Screenshots image

Additional context Hope adding an issue for this feature on Github is not an issue. I tried to adjust wait times between steps on a local build myself, but still can't figure this out. Sorry to bother and thanks in advance.

Jaksuhn commented 2 months ago

this depends on the auto refresh tweak in simple tweaks, which is not updated yet

I'll leave the issue up though cause maybe I can natively integrate it or something similar

ahernika commented 2 months ago

got it, Thank you

GitJohnSmith commented 2 months ago

Hi, is it possible to allow us to have a custom delay on how fast the plugin goes when it's adjusting the retainer's listings? Or, just have it detect that it is stuck on the "please wait and try again" screen and it'll just refresh that page again? Thanks!

FVollbrecht commented 2 months ago

this depends on the auto refresh tweak in simple tweaks, which is not updated yet

I'll leave the issue up though cause maybe I can natively integrate it or something similar

Can't find the setting in simple tweaks.

MapleEmbers commented 2 months ago

this depends on the auto refresh tweak in simple tweaks, which is not updated yet I'll leave the issue up though cause maybe I can natively integrate it or something similar

Can't find the setting in simple tweaks.

"which is not updated yet" we just gotta wait

alyssadev commented 1 month ago

Could throttle the requests, have an internal timer for whatever the request timeout is from the moment the price list is loaded. Or, could implement the tweak into Automaton https://github.com/Caraxi/SimpleTweaksPlugin/blob/main/Tweaks/RefreshMarketPrices.cs