search

JakubKoralewski / lets-watch-it-together-private

Unconnected fork of LWIT. Private for the duration of SCRUM project.
https://lets-watch-it-together-scrum.herokuapp.com
MIT License
1 stars 0 forks source link

feat: add Text To Speech #23

Closed JakubKoralewski closed 3 years ago

JakubKoralewski commented 3 years ago

https://user-images.githubusercontent.com/43069023/106650914-bd921f00-6593-11eb-8261-ef1d4b1844ce.mp4

Closes #4

JakubKoralewski commented 3 years ago

ok it's deployed pls check it out, there are following "bugs":

  1. only speaking in /app/welcome: the long text spoken above is only spoken on /app/welcome, this was at first to have different greeting for returning user and for first time user, but since I put the long thing in the place where the first time user logs in it is only spoken there
  2. have to click: on chrome there's a bug such that the user needs to click something (same as with music) to make the voice play (on firefox the voice can speak without clicking actually on my machine) but we use a different click event listener from the BackgroundMusic component by @syrekable, so u need to click for the voice to start speaking, even though for me the music can play without having to click we may want to merge this somehow into one event listener idk

so there's things we can still fix in sprint 3 i guess

Yurii17K commented 3 years ago

Checked in chrome. I don't hear the tts. Have u deployed it to the main scrum? I mean our private scrum

Yurii17K commented 3 years ago

And I bypassed git auth xd

Yurii17K commented 3 years ago

Checked via my phone and after it tried to open git login page I got through Screenshot_2021-02-02-22-09-19-197_com.android.chrome.png

AdrianKlessa commented 3 years ago

Doesn't work for me on https://lets-watch-it-together-scrum.herokuapp.com/app right now. Checked in Firefox and chrome. I can hear music but no voice unfortunately. Clicking only causes the music to begin playing again.

JakubKoralewski commented 3 years ago

Ok guys I feel like I need to explain how Review Apps and merging pull requests works here :D no worries my bad i didnt explain it before, so:

Have u deployed it to the main scrum? I mean our private scrum

It only is deployed if we merge this pull request, so no

Doesn't work for me on lets-watch-it-together-scrum.herokuapp.com/app right now.

I use Heroku to create a Review App, which builds the current branch in this PR so that you can see how the website will look like after merging, without actually merging

you can see that it is deployed here:

obraz

(idk maybe it doesnt show up for you? cause github/heroku permission stuff?)

i need to deploy a PR manually cause I'm going to run out of free Heroku hours per month if it would be deployed for every PR so since it only shows up when I click I guess it is confusing it doesn't appear right away

tldr; all in all, PRs get deployed to such URLs https://lwit-scrum-private-pr-23.herokuapp.com/ and its only in main once you merge, so check if it works on this URL and if its all fine we can merge

JakubKoralewski commented 3 years ago

And I bypassed git auth xd

how did you hack it ? 😮

Yurii17K commented 3 years ago

Ok guys I feel like I need to explain how Review Apps and merging pull requests works here :D no worries my bad i didnt explain it before, so:

Have u deployed it to the main scrum? I mean our private scrum

It only is deployed if we merge this pull request, so no

Doesn't work for me on lets-watch-it-together-scrum.herokuapp.com/app right now.

I use Heroku to create a Review App, which builds the current branch in this PR so that you can see how the website will look like after merging, without actually merging

you can see that it is deployed here:

obraz

(idk maybe it doesnt show up for you? cause github/heroku permission stuff?)

i need to deploy a PR manually cause I'm going to run out of free Heroku hours per month if it would be deployed for every PR so since it only shows up when I click I guess it is confusing it doesn't appear right away

tldr; all in all, PRs get deployed to such URLs https://lwit-scrum-private-pr-23.herokuapp.com/ and its only in main once you merge, so check if it works on this URL and if its all fine we can merge

I knew that it has mechanics like this, but didn't know the actual process. Tho i had this "view deploy" button each time except today

Yurii17K commented 3 years ago

Everything works for me now. Long message in /welcome SHort in /app

Yurii17K commented 3 years ago

And I bypassed git auth xd

how did you hack it ? 😮

opened main scrum deployed app via phone's chrome clicked login, it asked me which app to choose (git or chrome), i chose chrome it kinda lagged once and then asked me the same thing after 2nd time i got to the page in the screenshot

AdrianKlessa commented 3 years ago

Oh well, I knew I was doing something wrong. EIther way, I've seen that page already but didn't know how to log in with test users tbh. Did it know and it works. Thanks!