search

JakubOnderka / PHP-Parallel-Lint

This tool check syntax of PHP files faster than serial check with fancier output.
Other
647 stars 62 forks source link

Add checkstyle support #119

Closed kamazee closed 6 years ago

kamazee commented 6 years ago

Quick approach to solving #118

kamazee commented 6 years ago

This is a proof of concept, waiting for feedback on whether there's a chance to have it merged when tests and other concerns are sorted and build is green, or having checkstyle.xml-like output support is not something that the PHP-Parallel-Lint should support.

kamazee commented 6 years ago

Update: tests now pass, backward compatibility for Settings class is preserved (json property is exposed via magic methods that check new 'format' field).

kamazee commented 6 years ago

FYI: failure in travis is related to a composer bug: composer/composer#7510. I'll try to fix it somehow.

kamazee commented 6 years ago

@JakubOnderka this is ready for review. I also fixed failures on both Travis and Appveyor (the former sucked quite a lot of blood out of me to debug the issue with composer).

If checkstyle is not an option, let me know, and I'll change the PR in order to fix the CI at least.

kamazee commented 6 years ago

Rebased, addressed review notes, discarded build-related changes that are not needed anymore, and added tests for json/checkstyle CLI switches.

JakubOnderka commented 6 years ago

Looks great, thanks! New version will be released soon, after merging other PR.