search

JakubOnderka / PHP-Parallel-Lint

This tool check syntax of PHP files faster than serial check with fancier output.
Other
647 stars 62 forks source link

Add subdirectory exclude support #19

Closed smugryan closed 10 years ago

smugryan commented 10 years ago

(This is somewhat of a hack, open to suggestions).

With our codebase we need to exclude subdirectories (foo/bar/baz). Currently PHP-Parallel-Lint only supports excluding top level directories. This PR adds support for excluding subdirectories.

I had to add "." in getPathname due to Unix relative directories being listed as './foo' instead of just '/foo'. I don't have a Windows machine to verify it works there as well. (Or if this is even the best method.)

I'm fairly unfamiliar with the Iterator PHP stuff, so I'm open to hearing better ways to do this.

smugryan commented 10 years ago

Whoops, missing a commit. Will update asap.

grogy commented 10 years ago

Can you please add unit test?

smugryan commented 10 years ago

Sure, will do.

grogy commented 10 years ago

:+1:

Thanks, now it look OK.

smugryan commented 10 years ago

Great! Will it be merged in? I really need this for a project. Thank you!

JakubOnderka commented 10 years ago

Merged. Thanks! The next stable version 0.6 will be released soon.

smugryan commented 10 years ago

Thanks!