search

JakubOnderka / PHP-Parallel-Lint

This tool check syntax of PHP files faster than serial check with fancier output.
Other
647 stars 62 forks source link

PHP 5.3 support #36

Closed grogy closed 10 years ago

grogy commented 10 years ago

Hi,

interface JsonSerializable is used in project. But interface was defined until in PHP 5.4 [1]. PHP 5.3 is dead actually [2]. However PHP 5.3 will used in elderly project and hostings.

What we do with it? I have two solution.

A/ Change support to PHP 5.4 and newest. B/ Remove used interface and replace custom interface. (not ok, I think it is bad solution) C/ Other solution?

[1] http://php.net/manual/en/class.jsonserializable.php [2] http://php.net/archive/2014.php#id2014-08-14-1

JakubOnderka commented 10 years ago

I probably drop support for PHP 5.3.

Use own interface instead of JsonSerializable is not necessary, because it is possible to test, if this interface not exists and then define this interface, but I must own implementation for json_encode.

And testing syntax against 5.3 version will be preserved, because user can specify different PHP executable to run lint process.

Do you think it is a good solution?

grogy commented 10 years ago

Yes, I agree.

We can add information to README for PHP 5.3, too. - Users can use elderly version of this tool.

JakubOnderka commented 10 years ago

Version with dropped PHP 5.3 support is in current master branch.