Closed Krinkle closed 10 years ago
You should add it to the allow_failure
matrix.
@fprochazka I'd rather not. The fix is trivial. I've added it to the commit.
But that test must be fixed before this can be accepted :)
I think that you should either add it to the allow_failure
matrix, or fix the test.
I've already fixed the test (amended the commit, see a1981d054b6e). The failing test now is in a lower dependency that probably contains similar ugly hacks that rely on Zend-specific behaviour.
It would probably run if you allow @dev
version of nette/tester
@fprochazka: Might be the case, but not everyone is willing to use unstable versions. Moreover, it's not @Krinkle's fault that @JakubOnderka set nette/tester dependency to ~1.1
.
@Krinkle Many thanks for your change! Now is hhvm in allow_failures matrix, but after new version Nette Tester with hhvm support is released, I remove hhvm test from the allow_failures.
nette/tester#156 has been fixed and released as 1.3.0. Now we need PHP-Parallel-Lint to update dependency and also make a (minor) release.
@Krinkle: https://github.com/JakubOnderka/PHP-Parallel-Lint/commit/77e4e709e918db27199030e8dfc6df25d6ece6e1, @JakubOnderka, could you tag it? (BTW Travis is blocked by https://github.com/travis-ci/travis-ci/issues/2806 (but hhvm-nightly should work well with Tester already).
Tagged as v0.8 – https://github.com/JakubOnderka/PHP-Parallel-Lint/releases/tag/v0.8
I ran into this when using composer to build a project on a server that uses HHVM with php54 compat. Composer satisfied the php version requirement with hhvm, but the test still failed (early on) inside PHP-Parallel-Lint. Its parent process uses
PHP_VERSION_ID
but the lint subprocesses fail due to it usingphp -v
.Blocked on nette/tester#156 going into a release.