search

JakubOnderka / PHP-Parallel-Lint

This tool check syntax of PHP files faster than serial check with fancier output.
Other
647 stars 62 forks source link

Swap else if to elseif #85

Closed reedy closed 8 years ago

reedy commented 8 years ago

elseif is more performant, see https://secure.php.net/elseif

reedy commented 8 years ago 
 114 | ERROR | [x] Usage of ELSEIF not allowed; use ELSE IF instead
     |       |     (Squiz.ControlStructures.ElseIfDeclaration.NotAllowed)

I mean, really? Why?

Can I amend this commit and/or add another commit to remove

<rule ref="Squiz.ControlStructures.ElseIfDeclaration"/>
JakubOnderka commented 8 years ago

I started using else if because of JavaScript syntax, I do not want to keep in mind if I write app in JS or in PHP. And PSR-2 only recommends to use elseif, so I close this PR. Sorry.

reedy commented 8 years ago

But you remember to add <?php where necessary?