Fixed files skipping based on version_compare() in Windows

JakubOnderka / PHP-Parallel-Lint

This tool check syntax of PHP files faster than serial check with fancier output.

Other

647 stars 61 forks source link

Fixed files skipping based on version_compare() in Windows #92

Closed kukulich closed 7 years ago

kukulich commented 7 years ago

There's a strange bug in Windows when using version_compare(). The previous code !version_compare(PHP_VERSION, $m[2], $m[1]) doesn't return expected values. However the strict comparison === false works.

I added the strict comparison and simplified the code a little.

JakubOnderka commented 7 years ago

It looks better now :) Thanks

kukulich commented 7 years ago

@JakubOnderka Thanks. Do you have any plans for release?

grogy commented 7 years ago

I agree with @kukulich

Last release was in 2015 - it is so long time ago. Please, create new release.

JakubOnderka commented 7 years ago

I want to solve #90 and then release new version