search

JaleelB / emblor

A fully-featured tag input component built with shadcn/ui
https://emblor.jaleelbennett.com
MIT License
542 stars 24 forks source link

Tag Shapes Property - Rounded vs Pill #3

Closed aryanprince closed 7 months ago

aryanprince commented 7 months ago

Summary

Hey, just wanted to point out that the pill shape buttons and rounded shape buttons in the UI components seem to be swapped. I could be totally wrong, but I thought I'd ask if that's what you intended. I'd like to make a PR for this if this was unintentional :)

Possible solution

In the shape property for the tag-input.tsx component, rounded could be rounded-lg and pill could be rounded-full, like the image I found online on the right:

image image

Current screenshots from demo website:

Rounded (for shadcn-tag-input):

image

Pill (for shadcn-tag-input):

image

JaleelB commented 7 months ago

Hey, this was unintentional. Thanks for pointing that out. Create the PR, and I'll approve it right away