Closed asaf closed 1 month ago
+1 to this. Not having a popover makes this library a no-go for mobile devices
https://github.com/JaleelB/emblor/assets/78449846/109d251c-12a8-4307-b70a-14dc5aa2b2ab
@asaf This is something you can already do by passing the usePopoverForTags boolean. See the general properties under the API reference page: https://emblor.jaleelbennett.com/api-reference
But the list of all possible tags is always opened and with static 10 elements.
Isn't it only shows the entered tags? @JaleelB
But the list of all possible tags is always opened and with static 10 elements.
@asaf What do you mean by static 10 elements? You can extend the number of items in the list of auto-complete options. Regarding the list of auto-complete options always being shown, I see what you mean. I'll add a feature to only show it on input focus or something. That was a misunderstanding on my part with your original comment
Isn't it only shows the entered tags? @JaleelB
@kavinda1995 Yes, the popover shows the entered tags to prevent them from causing a long tag list which could possibly cause layout shifts. Regarding the possible options, I will work on a feature to toggle showing it list on focus or something. I misunderstood the original comment
I think it make sense, it can shrink down into a sort of a selectbox to avoid taking large portion of the screen :) this is somewhat relevant to https://github.com/JaleelB/emblor/issues/29
@asaf @kavinda1995
The enhancements discussed in this thread have been addressed in the v1.2.0 release.
onBlur
and onFocus
events.Thank you for your feedback! Feel free to test the new version and provide further feedback if needed.
When autoComplete is enabled, I suggest making it possible to render the possible options inside a popover to avoid allocating too much screen space for this component.
Such as the Status dropdown filter in https://ui.shadcn.com/examples/tasks