search

JaleelB / emblor

A fully-featured tag input component built with shadcn/ui
https://emblor.jaleelbennett.com
MIT License
542 stars 24 forks source link

Feature request: Autocomplete Overflow #6

Closed jacquesuhlemann closed 6 months ago

jacquesuhlemann commented 6 months ago

Currently the autocomplete shows all existing tags, the list can become very long.

It would be perfect to use autocomplete in an overflow. Perhaps even in a popover so that other elements underneath are not moved too far.

Great work and many thanks

JaleelB commented 6 months ago

Hey @jacquesuhlemann. Thanks for the love, I appreciate it.

If I am understanding what you are saying, then a workaround to that issue is setting a max with on the container the autocomplete input is in.

The popover feature is a good feature idea. I am currently working on a few iterations. I'll push what I have in a bit

eliza921 commented 6 months ago

I have tried with the Popover component and it was almost good! The only problem I noticed was when attempting to select the first tag it required two-clicks, which is not the intended behavior.

As a workaround, I tried wrapping the element with a component from shadcn.

JaleelB commented 6 months ago

@jacquesuhlemann @eliza921 Thank you for your valuable feedback and suggestions regarding the Tag Input component. I've gone ahead and implemented the features you requested! Try it out and let me know what you think

https://github.com/JaleelB/shadcn-tag-input/assets/78449846/ab0cbf96-8a44-4326-a759-f1111c5f073e