Jaliborc / BagBrother

Shared services and codebase between Bagnon and Bagnonium
7 stars 33 forks source link

Searching cached Bank window returns bad results and GetItemLink errors #13

Closed InvisiBilldotnet closed 1 year ago

InvisiBilldotnet commented 1 year ago

Running Software (issues missing this information will be deleted):

Describe the bug When searching the cached Bank frame, all items in bags (outside the default first bank bag) are highlighted. Search functions normally while at a banker.

To Reproduce Steps to reproduce the behaviour:

  1. Open cached Bank window with /bgn bank
  2. Search for something
  3. See almost all items highlighted, "GetItemLink" errors
  4. Repeating the search in a banker window works as expected without errors

Expected behaviour Only items matching the search should be highlighted.

Screenshots Searching in cached Bank window (224 items highlighted) image

Searching at actual banker window (4 items highlighted) image

Error Logs

10x bad argument #1 to '?' (Usage: local itemLink = C_Item.GetItemLink(itemLocation))
[string "=[C]"]: in function `GetItemLink'
[string "@BagBrother/libs/ItemSearch-1.3-1/API.lua"]:40: in function `Matches'
[string "@BagBrother/addons/core/classes/item.lua"]:296: in function `UpdateSearch'
[string "@BagBrother/addons/core/classes/item.lua"]:214: in function `func'
[string "@BagBrother/libs/MutexDelay-1.0-2/MutexDelay-1.0.lua"]:36: in function <...ns/BagBrother/libs/MutexDelay-1.0/MutexDelay-1.0.lua:30>

Locals:
(*temporary) = "bad argument #1 to '?' (Usage: local itemLink = C_Item.GetItemLink(itemLocation))"