Jaliborc / BagBrother

Shared services and codebase between Bagnon and Bagnonium
7 stars 33 forks source link

Updating/Fixing the Clean up for special bag types #37

Open ChilledTrong opened 12 months ago

ChilledTrong commented 12 months ago

putting this under a feature because i don't think its a taint or bug because its not breaking anything it just might be need a slight alter i have been going through sorting my bank and adjusting the sort properties in the Bagbrother\Core\Api\Sorting.lua to get a better understanding of what the parameters are for the clean up feature and what ive noticed is that it doesn't know how to prioritize items what i mean by this is that it wont move an item that can go into more than one special bag types. even if it has room for them here are a few examples Note: i have also moved the bag slots around and put basic bags between them to see if it would then put the materials together but it does not. and reversing bag slot order doesn't change anything only how its shown to me, because i don't think there is a option for it sort items by its properties in reverse order or even by simply switching what it views as slot 1 and last slot

so here are my bags not full sorted you can see some Ore and Bars around. WowClassic_GnGfJh11cj

Now after auto sort it looks like this you can see its moved those materials up to the top because the mining bag is full and can see where its left space in the Engineering Bag WowClassic_zZPquNyO31 and now i manually move the items showing that they can all fit in both bags because Elemental materials are allowed in both Special Bag Types, but the sorting ignores that. WowClassic_xVZBo2pH4F and now i click sort gain and we end up back where we started ezgif-1-3567bb5a82

that said, because of everyone having there own way of how they want to sort things means you cant please everyone, and im very happy with the addon been using it forever. i didn't want be rude submitting one of these and hoped i could figure out the right combination to sort it myself but change to much and it breaks. and im not great with coding.

the fixes that come to mind would having special bag types prioritize of normal bags and have items that can fit multiple bag types have less priority to those that cant so it wont ignore items while having free space.

but since its not technically broken i was wondering maybe if you could add a little text info of how people can go about sorting it how they want it or in terms of features, maybe more sort "styles" or "filters", or potentially sort "profiles" that could be imported/exported and shared amongst the community