search

Jaliborc / Bagnon

Single window displays for you items
200 stars 112 forks source link

Addon taint #1120

Open Lethay opened 4 years ago

Lethay commented 4 years ago

Running Software (issues missing this information will be deleted):

Describe the bug Addon taints a secure function immediately upon opening bags. I'm not such which, but it's either :GetChildren or :GetPoint. It completely breaks my UI every time this happens, which is unfortunately every time. I had to roll back from 8.2.27 to 8.2.16 to fix this (I didn't try any intermediate versions).

To Reproduce

  1. Open bags.
  2. Attempt to use GetChildren or GetPoint (not sure which) in any other addon.

Expected behaviour Not having my entire UI (ConsolePort) locked out.

Error Logs I'm sorry, I didn't keep this, but it's the standard error message about insecure code attempting to hook secure functions.

Lethay commented 4 years ago

Actually, I'm not 100% sure I've tracked this down exactly. What I know:

  1. I definitely get taint / "Cannot call restricted closure from insecure code" by simply opening bags with a. Bagnon version 8.2.27 b. Bagnon version 8.2.19 I don't get the issue with Bagnon version 8.2.16.

  2. However, with 8.2.16, I get the issue after trying to disenchant items (once out of two attempts), but I had never had this issue before today, which suggests that I have updated another addon - but I cannot find which. Possible culprits, that have had an update since the 22nd of December, are:

    • (Bagnon)
    • Leatrix maps
    • AtlasLootClassic
    • Questie
    • Spy Classic
    • DejaClassic Stats
    • ClassicCastBars
    • ClassicAuraDurations

But none of these obviously affect enchanting, bags or tooltips, which leaves me at a loss.

Road-block commented 4 years ago

Try 8.2.16 as you have been doing but after clearing bagnon saved variables and starting fresh.
See if that changes things.

Lethay commented 4 years ago

I did indeed continue using 8.2.16 and didn't get a repeat problem, from disenchanting or otherwise, I just didn't comment here because "nothing has happened - yet" is not very conclusive.