search

Jaliborc / Bagnon

Single window displays for you items
195 stars 111 forks source link

An action was blocked because of taint from Bagnon - UseContainerItem() #1293

Open clausjoergensen opened 3 years ago

clausjoergensen commented 3 years ago

Running Software (issues missing this information will be deleted):

Describe the bug Taint in UseContainerItem() and also in GameTooltipMoneyFrame1 (probably unrelated)

To Reproduce Occasionally happens when clicking an item in the bag. I've seen it happen when clicking a mana potion (while in combat), and combining 10 motes of mana (while out of combat)

Expected behaviour No taint

Error Logs

6/13 22:51:22.868  An action was blocked because of taint from Bagnon - UseContainerItem()
6/13 22:51:22.868      Interface\FrameXML\ContainerFrame.lua:1266 ContainerFrameItemButton_OnClick()
6/13 22:51:22.868      BagnonItem160:OnClick()
6/13 22:52:37.290  Execution tainted by Bagnon while reading GameTooltipMoneyFrame1 - Interface\FrameXML\MoneyFrame.lua:312 MoneyFrame_Update()
6/13 22:52:37.290      Interface\FrameXML\GameTooltip.lua:331 SetTooltipMoney()
6/13 22:52:37.290      Interface\AddOns\VendorPrice\VendorPrice.lua:51 SetPrice()
6/13 22:52:37.290      Interface\AddOns\VendorPrice\VendorPrice.lua:75
6/13 22:52:37.290      SetBagItem()
6/13 22:52:37.290      Interface\FrameXML\ContainerFrame.lua:1352 ContainerFrameItemButton_OnEnter()
6/13 22:52:37.290      Interface\AddOns\Bagnon\common\Wildpants\classes\item.lua:369 BagnonItem160:ShowTooltip()
6/13 22:52:37.290      Interface\AddOns\Bagnon\common\Wildpants\classes\item.lua:340 BagnonItem160:UpdateTooltip()
6/13 22:52:37.290      Interface\FrameXML\GameTooltip.lua:496
Goldpaw commented 3 years ago

UseContainerItem fails because the moneyframe somehow has become tainted. The tooltip is shown upon entering the button, and thus its functionality breaks.

I am almost certain this has nothing to do with bagnon, though. I see this error popping up all over for no apparent reasons, and it often happens to the quest buttons in the objectives tracker too. And there too, they blame the moneyframe for being tainted. Which it is not.