Jaliborc / Bagnon

Single window displays for you items
200 stars 112 forks source link

Latest 3.4.0 beta 9.2.3 update broke the addon #1413

Closed Nillx closed 2 years ago

Nillx commented 2 years ago

9.2.3 broke the addon in wotlk. Im getting this error now

20x ...\Bagnon\common\Wildpants\classes\currencyDisplay.lua:45: attempt to call field 'GetBackpackCurrencyInfo' (a nil value)
[string "@Bagnon\common\Wildpants\classes\currencyDisplay.lua"]:45: in function `Update'
[string "@Bagnon\common\Wildpants\classes\currencyDisplay.lua"]:39: in function `RegisterEvents'
[string "@Bagnon\common\Wildpants\classes\currencyDisplay.lua"]:25: in function <...\Bagnon\common\Wildpants\classes\currencyDisplay.lua:13>
[string "=(tail call)"]: ?
[string "@Bagnon\addons\main\frame.lua"]:319: in function `PlaceCurrency'
[string "@Bagnon\addons\main\frame.lua"]:97: in function `Layout'
[string "@Bagnon\addons\main\frame.lua"]:66: in function `Update'
[string "@Bagnon\addons\main\frame.lua"]:56: in function `RegisterSignals'
[string "@Bagnon\common\Wildpants\classes\frame.lua"]:19: in function <...aceBagnon\common\Wildpants\classes\frame.lua:17>
[string "=(tail call)"]: ?
[string "@Bagnon\common\Wildpants\classes\inventory.lua"]:21: in function <Bagnon\common\Wildpants\classes\inventory.lua:20>
[string "=[C]"]: in function `Show'
[string "@Bagnon\common\Wildpants\api\frames.lua"]:85: in function `Show'
[string "@Bagnon\common\Wildpants\api\frames.lua"]:77: in function `Toggle'
[string "@Bagnon\common\Wildpants\features\autoDisplay.lua"]:184: in function `ToggleAllBags'
[string "OPENALLBAGS"]:1: in function <[string "OPENALLBAGS"]:1>

Locals:
self = <unnamed> {
 0 = <userdata>
 frame = BagnonInventoryFrame1 {
 }
 Text = <unnamed> {
 }
}
v = ""
(for index) = 1
(for limit) = 3
(for step) = 1
i = 1
(*temporary) = nil
(*temporary) = 1
(*temporary) = "attempt to call field 'GetBackpackCurrencyInfo' (a nil value)"
Sepulchre49 commented 2 years ago

I too am experiencing this error. From my digging with the /api command, it appears that C_CurrencyInfo.GetBackpackCurrencyInfo() is missing from the WOTLK Classic API.

Sepulchre49 commented 2 years ago

I managed to get a fix together for this. The C_CurrencyInfo namespace does not exist in game client 3.4.0 (WOTLK), so this function as well as SetCurrencyBackpack need to be called globally. The file causing the errors is Bagnon\common\Wildpants\classes\currencyDisplay.lua.

I would like to submit a pull request to fix this, but the file currencyDisplay.lua does not appear in the Wildpants repository (perhaps it was added sometime in the past five days? Please tell me how you'd like me to proceed.

Jaliborc commented 2 years ago

Don't worry with a PR, the beta is just a demo for a poll, code is temporary. You can help instead by answering the strawpoll: https://www.patreon.com/posts/bagnon-currency-71748089

Dubbeldrank commented 2 years ago

Currently the add-on is broken and i disabled it, any news on a fix? :)

Jaliborc commented 2 years ago

If you have problem with the demo, please install the release build. Betas are not necessarily bug-free. There won't be further updates this month unfortunately. Check @GGDAG comment below for instructions.

Burdarper commented 2 years ago

Looks like broken beta got relaesed ;-/

Any hints on the fix Sepulchre49 mentioned ?

GGDAG commented 2 years ago

If you use curseforge you an easily click your way to versions and install "Bagnon-9.2.2-3.4.0.zip" instead, which works fine for me

themistiq2694 commented 2 years ago

The file causing the errors is Bagnon\common\Wildpants\classes\currencyDisplay.lua.

If you create an empty txt file in that folder with same name. it will work just fine so far from what I have tested.

                                                     Signed: Justevil@Firemaw