Jaliborc / Bagnon

Single window displays for you items
189 stars 107 forks source link

Getting an error when picking colors for other addons #1884

Closed jmaslows closed 2 months ago

jmaslows commented 4 months ago

Which software were you running?

Have you read the changelog? Mark if read.

Please describe the bug. Cannot change color in other addons. Get a bug error. Sexymap and weakauras both give errors if bagnon is enabled.

Please describe how to reproduce it. Have bagnon and weakauras enabled only. Import https://wago.io/9h1Vqjhbi. Open weakauras and under display tab try and change text color. Works fine if bagnon is disabled.

or

install sexymap and bagnon only. In sexymap options go to clock or coordiantes and try and change background or border color.

The issue seems to be a shared library in Ace called color picker.

Any Screenshots? https://i.imgur.com/w9p1Kkh.png

Error Logs are Important! 80x ...Libs/AceGUI-3.0-41/widgets/AceGUIWidget-ColorPicker.lua:80: attempt to call method 'GetColorAlpha' (a nil value) [string "@BigDebuffs/Libs/AceGUI-3.0-41/widgets/AceGUIWidget-ColorPicker.lua"]:80: in function `opacityFunc'

[string "=[C]"]: in function `SetValue'

[string "=[C]"]: in function Show' [string "@Interface_Wrath/FrameXML/UIParent.lua"]:2799: in functionShowUIPanel' [string "@FrameXML/UIDropDownMenu.lua"]:1452: in function OpenColorPicker' [string "@BagBrother/libs/Sushi-3.2-1/classes/checks/Color.lua"]:23: in functionSetupColorPickerAndShow' [string "@BigDebuffs/Libs/AceGUI-3.0-41/widgets/AceGUIWidget-ColorPicker.lua"]:94: in function <...Libs/AceGUI-3.0/widgets/AceGUIWidget-ColorPicker.lua:56>

Locals: r = 0 g = 0 b = 0 (temporary) = nil (temporary) = ColorPickerFrame { BottomLeftCorner = Texture { } OnBackdropLoaded = defined @SharedXML/Backdrop.lua:152 GetBackdropColor = defined @SharedXML/Backdrop.lua:390 TopLeftCorner = Texture { } RightEdge = Texture { } SetupColorPickerAndShow = defined @BagBrother/libs/Sushi-3.2/classes/checks/Color.lua:23 ApplyBackdrop = defined @SharedXML/Backdrop.lua:294 SetBackdrop = defined @SharedXML/Backdrop.lua:329 ClearBackdrop = defined @SharedXML/Backdrop.lua:282 hasOpacity = true GetBackdropBorderColor = defined @SharedXML/Backdrop.lua:409 GetBackdrop = defined @SharedXML/Backdrop.lua:347 SetBorderBlendMode = defined @SharedXML/Backdrop.lua:266 opacity = 0 func = defined @BigDebuffs/Libs/AceGUI-3.0/widgets/AceGUIWidget-ColorPicker.lua:71 backdropInfo =

{ } OnBackdropSizeChanged = defined @SharedXML/Backdrop.lua:182 HasBackdropInfo = defined @SharedXML/Backdrop.lua:278 GetEdgeSize = defined @SharedXML/Backdrop.lua:188 cancelFunc = defined @BigDebuffs/Libs/AceGUI-3.0/widgets/AceGUIWidget-ColorPicker.lua:85 0 = TopEdge = Texture { } previousValues =
{ } TopRightCorner = Texture { } Center = Texture { } SetupTextureCoordinates = defined @SharedXML/Backdrop.lua:214 SetBackdropBorderColor = defined @SharedXML/Backdrop.lua:422 BottomEdge = Texture { } BottomRightCorner = Texture { } SetupPieceVisuals = defined @SharedXML/Backdrop.lua:246 SetBackdropColor = defined @SharedXML/Backdrop.lua:399 LeftEdge = Texture { } opacityFunc = defined @BigDebuffs/Libs/AceGUI-3.0/widgets/AceGUIWidget-ColorPicker.lua:78 } (*temporary) = "attempt to call method 'GetColorAlpha' (a nil value)" ColorCallback = defined @BigDebuffs/Libs/AceGUI-3.0/widgets/AceGUIWidget-ColorPicker.lua:21 self =
{ a = 1 b = 0 parent =
{ } g = 0 OnAcquire = defined @BigDebuffs/Libs/AceGUI-3.0/widgets/AceGUIWidget-ColorPicker.lua:129 SetDisabled = defined @BigDebuffs/Libs/AceGUI-3.0/widgets/AceGUIWidget-ColorPicker.lua:156 userdata =
{ } base =
{ } HasAlpha = true type = "ColorPicker" SetHasAlpha = defined @BigDebuffs/Libs/AceGUI-3.0/widgets/AceGUIWidget-ColorPicker.lua:152 r = 0 text = FontString { } colorSwatch = Texture { } events =
{ } AceGUIWidgetVersion = 28 frame = Button { } SetLabel = defined @BigDebuffs/Libs/AceGUI-3.0/widgets/AceGUIWidget-ColorPicker.lua:140 SetColor = defined @BigDebuffs/Libs/AceGUI-3.0/widgets/AceGUIWidget-ColorPicker.lua:144 }

NayooZ commented 4 months ago

Dev still hasn't bothered to fix the issue that has had a PR open since last month fixing the problem.

https://github.com/Jaliborc/Sushi-3.2/pull/15

Existing issues referencing this exact same problem already: https://github.com/Jaliborc/Bagnon/issues/1874 https://github.com/Jaliborc/Bagnon/issues/1875

jmaslows commented 3 months ago

Is there an easy way to download the file I need to replace or does this require me to copy and paste the fix myself?

On Mon, Mar 4, 2024 at 5:27 AM NayooZ @.***> wrote:

Dev still hasn't bothered to fix the issue that has had a PR open since last month fixing the problem.

Jaliborc/Sushi-3.2#15 https://urldefense.com/v3/__https://github.com/Jaliborc/Sushi-3.2/pull/15__;!!IKRxdwAv5BmarQ!dRl5vvmsBM5U9Hva2vM64mHd7xn_49Fph4hEYBfH49D1dIbDAnLDRd9iyeRjH0lry2x26vU0UaA23GXm-1a7TF90khuh$

Existing issues referencing this exact same problem already:

1874

https://urldefense.com/v3/__https://github.com/Jaliborc/Bagnon/issues/1874__;!!IKRxdwAv5BmarQ!dRl5vvmsBM5U9Hva2vM64mHd7xn_49Fph4hEYBfH49D1dIbDAnLDRd9iyeRjH0lry2x26vU0UaA23GXm-1a7TIMdxvZG$

1875

https://urldefense.com/v3/__https://github.com/Jaliborc/Bagnon/issues/1875__;!!IKRxdwAv5BmarQ!dRl5vvmsBM5U9Hva2vM64mHd7xn_49Fph4hEYBfH49D1dIbDAnLDRd9iyeRjH0lry2x26vU0UaA23GXm-1a7TNaDUKg2$

— Reply to this email directly, view it on GitHub https://urldefense.com/v3/__https://github.com/Jaliborc/Bagnon/issues/1884*issuecomment-1976473051__;Iw!!IKRxdwAv5BmarQ!dRl5vvmsBM5U9Hva2vM64mHd7xn_49Fph4hEYBfH49D1dIbDAnLDRd9iyeRjH0lry2x26vU0UaA23GXm-1a7TCb878rv$, or unsubscribe https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ACB5AU5M3EURUTZRHXIJWQLYWRSCBAVCNFSM6AAAAABECOTQ5KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZWGQ3TGMBVGE__;!!IKRxdwAv5BmarQ!dRl5vvmsBM5U9Hva2vM64mHd7xn_49Fph4hEYBfH49D1dIbDAnLDRd9iyeRjH0lry2x26vU0UaA23GXm-1a7THJEqGUc$ . You are receiving this because you authored the thread.Message ID: @.***>

NayooZ commented 3 months ago

You can grab the file out of the PR here, click on "Download raw file": https://github.com/Jaliborc/Sushi-3.2/blob/101c5247c646dc6cfc3af34726e7cc944318866a/classes/checks/Color.lua

Then you need to put it in this folder within your addons folder: BagBrother\libs\Sushi-3.2\classes\checks