Jaliborc / Bagnon

Single window displays for you items
194 stars 111 forks source link

Bagnon Not Working #1918

Open felbrex opened 1 month ago

felbrex commented 1 month ago

Which software were you running?

Have you read the changelog? Yes

Please describe the bug. After the new update today, I can't open my bags by clicking, using shift-b, or any other option. Even after turning Bagnon off, when I log back in, it will only open my main backpack.

Please describe how to reproduce it.

  1. Click on backpack
  2. Nothing happens
seascape195 commented 1 month ago

Confirmed bug in Add-on after today's server restart. Bags will not even open and the previous workaround to comment out the Button Line in the Pancho-2.0 file does not work to get around it this time either.

Bagbrother | Bagnon

Mhortai commented 1 month ago

Can also confirm after today's update addon no longer works. Can't open my bags etc.

seascape195 commented 1 month ago

Can also confirm after today's update addon no longer works. Can't open my bags etc.

Disable "Bagbrother" as a workaround (reverts to native wow bag manager)

TallerAndBlueOnline commented 1 month ago

Really annoying having it disabled altogether, but...yeah; I can confirm that it's completely broken.

Nightcrue commented 1 month ago

Same problem so I disabled BB for now.

OSDevon commented 1 month ago

It seems like today's update deprecated a bunch of APIs (something that addon authors have apparently had months to prepare for), so this really looks like a pretty bad lack of maintenance.

Mewohkie commented 1 month ago

Once again Bagnon is broken not even 4 days after being fixed. At this point the addon is down/broken more than it is up/working. Jaliborc, you do good work, but you don't do it fast enough, you gotta be on top of this stuff man. You can't just get it working for 4 days and bounce for months.

nyjl commented 1 month ago

jut go around and comment out/default to false all depcrecated calls, they all are about lib management, which i think was a stupid idea to use anyway in such a small addon

E:\games\World of Warcraft_retail_\Interface\AddOns\Bagnon\src\frame.lua:158

replace a call with false

function Frame:HasOptionsToggle()
    return false
end

E:\games\World of Warcraft_retail_\Interface\AddOns\BagBrother\core\classes\item.lua:177

just replace a call with false elseif Addon.sets.glowSets and false then

E:\games\World of Warcraft_retail_\Interface\AddOns\BagBrother\libs\C_Everywhere\C_Everywhere.lua:104

comment out

--if not C_Addons then
--  C.Addons.GetAddOnEnableState = function(addon, character)
--      return GetAddOnEnableState(character, addon)
--  end
--end
EmKev94 commented 1 month ago

jut go around and comment out/default to false all depcrecated calls, they all are about lib management, which i think was a stupid idea to use anyway in such a small addon

E:\games\World of Warcraftretail\Interface\AddOns\Bagnon\src\frame.lua:158

replace a call with false

function Frame:HasOptionsToggle()
  return false
end

E:\games\World of Warcraftretail\Interface\AddOns\BagBrother\core\classes\item.lua:177

just replace a call with false elseif Addon.sets.glowSets and false then

E:\games\World of Warcraftretail\Interface\AddOns\BagBrother\libs\C_Everywhere\C_Everywhere.lua:104

comment out

--if not C_Addons then
--    C.Addons.GetAddOnEnableState = function(addon, character)
--        return GetAddOnEnableState(character, addon)
--    end
--end

You are beast man , tyvm <3

darodriguesPT commented 1 month ago

jut go around and comment out/default to false all depcrecated calls, they all are about lib management, which i think was a stupid idea to use anyway in such a small addon

E:\games\World of Warcraftretail\Interface\AddOns\Bagnon\src\frame.lua:158

replace a call with false

function Frame:HasOptionsToggle()
  return false
end

E:\games\World of Warcraftretail\Interface\AddOns\BagBrother\core\classes\item.lua:177

just replace a call with false elseif Addon.sets.glowSets and false then

E:\games\World of Warcraftretail\Interface\AddOns\BagBrother\libs\C_Everywhere\C_Everywhere.lua:104

comment out

--if not C_Addons then
--    C.Addons.GetAddOnEnableState = function(addon, character)
--        return GetAddOnEnableState(character, addon)
--    end
--end

Thank you, these 3 changes did the trick :)

lloskka commented 1 month ago

Anyone can cloud this with fixes in ?!

So we can download

Still having issues on lines > 311 item.lua after doing these

bull88-freddy commented 1 month ago

Bagnon.zip

Jackicek commented 1 month ago

Anyone can cloud this with fixes in ?!

So we can download

Still having issues on lines > 311 item.lua after doing these

i maybe fixed problem on line 311. Just replace C.Addons.IsAddOnLoaded with C_AddOns.IsAddOnLoaded

bull88-freddy commented 1 month ago

Anyone can cloud this with fixes in ?! So we can download Still having issues on lines > 311 item.lua after doing these

i maybe fixed problem on line 311. Just replace C.Addons.IsAddOnLoaded with C_AddOns.IsAddOnLoaded

with change line 311

Bagnon.zip

LorenzoRogai commented 1 month ago

Latest version on Curseforge is now published, seems to work