Jaliborc / PetTracker

Tracks pets, alerts for upgrades and helps you in pet battles.
49 stars 26 forks source link

Timers missing for Enemy Pet Bar in new version #148

Open SirArioch opened 4 years ago

SirArioch commented 4 years ago

Running Softwar (issues missing this information will be deleted):

*Describe the bug Timers missing for Enemy Pet Bar in new version

To Reproduce Do a pet battle

Expected behaviour Timers were present for enemy pets prior to this update.

Screenshots No timer on enemy "Soothe" and "Cleansing Rain" though they are grayed out. image

Youzerfriendly commented 4 years ago

Motion Seconded. Took me a while to find out where the problem was, but I'm pretty sure this is it.

TurduckenMcNugget commented 4 years ago

Thirded. Would very much like to see the return of the numbers for tracking enemy cooldowns.

morticianoire commented 4 years ago

Yup same here they’ve gone since update :-/

Bloodleh commented 4 years ago

I digged through the code and the author forgot to initialize two local variables in file addons\main\classes\combat\abilityButton.lua:

After lines 23-27:

function Ability:Display(ability, target)
    if ability then
        local unusable = ability.cooldown or ability.requisite
        local color = (unusable or not ability.certain) and .5 or 1
        local modifier = ability:GetModifier(target)

Add these 2 lines:

        local cooldown = ability.cooldown
        local requisite = ability.requisite

And it will work.

SirArioch commented 4 years ago

Thanks Bloodleh, this fixed worked perfectly!!

Youzerfriendly commented 4 years ago

Worked like a charm! Thanks for that my friend!

Jaliborc commented 4 years ago

@Bloodleh That must be it.

morticianoire commented 4 years ago

Since new update still not getting timers

morticianoire commented 4 years ago

not getting the boxes eithe rof opponents attack list so unsure whats happened

morticianoire commented 4 years ago

image

hdidier commented 4 years ago

I haven't seen it stated this way, so just to add... I am seeing the timers on wild battles, but not on Trainer or Epic Pet battles. I'm also not seeing it on PVP, but I don't know if that's by design or not as I did not PVP prior to this week. Example of missing trainer is Farmer Nishi

morticianoire commented 4 years ago

I haven't seen it stated this way, so just to add... I am seeing the timers on wild battles, but not on Trainer or Epic Pet battles. I'm also not seeing it on PVP, but I don't know if that's by design or not as I did not PVP prior to this week. Example of missing trainer is Farmer Nishi

Yes you cld see the timers and stuff in pvp it’s gone again now which is frustrating given it’s pet battle week

BenBelatrix commented 4 years ago

I have the same problem - only in PVP pet battles... Very frustrating!