Jaliborc / PetTracker

Tracks pets, alerts for upgrades and helps you in pet battles.
49 stars 26 forks source link

PVP battles broken #189

Open FlorinI opened 4 years ago

FlorinI commented 4 years ago

Interface: 80300

Title: PetTracker

Notes: Tracking pets in and out of combat since 2012.

Author: Jaliborc (JoĂŁo Cardoso)

Version: 8.3.6

X-Category: Battle Pets

I read the changelog.

Describe the bug In PvP battles, opponent abilities are not displayed. Also, I cannot change my pet. I get the following error

Steps to reproduce the behaviour:

  1. Pick any pet team and click Find Battle from the Blizz UI. Choose a pet then click the button to swap it. You may not even get this far as the error also appears by itself Message: Interface\AddOns\PetTracker\addons\battle\battle.lua:128: attempt to perform arithmetic on field 'Turn' (a nil value) Time: Sat Apr 4 21:00:46 2020 Count: 1 Stack: Interface\AddOns\PetTracker\addons\battle\battle.lua:128: attempt to perform arithmetic on field 'Turn' (a nil value) [string "@Interface\AddOns\PetTracker\addons\battle\battle.lua"]:128: in function GetAbility' [string "@Interface\AddOns\PetTracker\addons\battle\enemyBar.lua"]:70: in function?' [string "@Interface\AddOns\Bartender4\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua"]:119: in function <...er4\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:119> [string "@Interface\AddOns\Bartender4\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua"]:29: in function <...er4\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:25> [string "@Interface\AddOns\Bartender4\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua"]:64: in function `Fire' [string "@Interface\AddOns\Bartender4\libs\AceEvent-3.0\AceEvent-3.0.lua"]:120: in function <...AddOns\Bartender4\libs\AceEvent-3.0\AceEvent-3.0.lua:119>

Locals:

Expected behaviour No error.

Screenshots If applicable, add screenshots to help explain your problem.

I tried the /console scriptErrors 1 , nothing new appeared.

szakii commented 4 years ago

Hello, I'm also experiencing this issue. I'm not having any error popups, however. I noticed that the enemy pet ability UI elements actually seem to be there as if I move the cursor where they are ought to be, I get the tooltips of the abilities. The UI elements are simply not seem to be drawn or behave as if they were drawn with 0 alpha. As for the pet switcher dialog - it does not get displayed automatically when a) the combat starts or b) one of my pet dies, only manually by I pressing its button. I've used this addon for a very long time, please fix this.

formigao commented 4 years ago

have problems too show enemy abilities but cds don't work enemies are always on cd

mem988 commented 4 years ago

Same problem. It would be ok if it simply does not work on pvp battle but the fact that it makes impossible to swap pets affect the pvp battle at the point that i need to disable the addon to do pvp

scottish-kat commented 4 years ago

PvP battles still broken.

ThatGuy116 commented 4 years ago

Would be nice if this could get a fix soon. It's been broken like this for a while.

beth82014 commented 4 years ago

So, several fixes later, this still isn't fixed. With all addons except Pet tracker turned off, I cannot see enemy pet abilities until you hover mouse over where they should be and you can see the tool tip flash up. Also, the switcher doesn't work at all. With settings turned on, it still uses Blizz UI. The version 8.3.5 was the last time this all worked. It seems that in the Addon list, 8.3.5 had a line for "Switcher". In newer versions, that is gone. Not sure how its related, but think I am going to stop using this. There are other addons that can do the other things Pet tracker does, but the things that are missing are what makes Pet tracker so awesome for me. I would just like to see this issue acknowledged, and know whether it just isn't going to be fixed or it can be worked on. The posts on this issue have gone back for several months.

Thanks