Open Daeveren opened 3 years ago
Temporary bypass: in addons\main\features\mapSearch.lua, comment out line 75: --overlay:SetScript('OnMouseDown', function() self:ToggleTrackingTypes(overlay) end)
Note this would also disable toggling feature for pettracker on the map button.
It looks like the menu is being replaced.
I suggest taking a look at how RareScanner is interacting with this menu. They do this by secure hooking the InitializeDropDown event for the frame and adding to the frame using UIDropDownMenu_AddSeparator, UIDropDownMenu_CreateInfo, and UIDropDownMenu_AddButton. This is done in the following file in RareScanner: RareScanner/Core/Service/RSWorldMapHooks.lua.
That creates game taint, and would not even allow for the editbox to be embedded. On Nov 29 2020, at 10:41 pm, Noshei notifications@github.com wrote:
It looks like the menu is being replaced. I suggest taking a look at how RareScanner is interacting with this menu. They do this by secure hooking the InitializeDropDown event for the frame and adding to the frame using UIDropDownMenu_AddSeparator, UIDropDownMenu_CreateInfo, and UIDropDownMenu_AddButton. This is done in the following file in RareScanner: RareScanner/Core/Service/RSWorldMapHooks.lua. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub (https://link.getmailspring.com/link/19DC0E24-7589-4C6A-9684-C09DFE2ED8F7@getmailspring.com/0?redirect=https%3A%2F%2Fgithub.com%2FJaliborc%2FPetTracker%2Fissues%2F235%23issuecomment-735469409&recipient=cmVwbHkrQUFETUNET0ZNU0RMUUtSWEtCU1g2QU41MkFDSkJFVkJOSEhDWUlHRklBQHJlcGx5LmdpdGh1Yi5jb20%3D), or unsubscribe (https://link.getmailspring.com/link/19DC0E24-7589-4C6A-9684-C09DFE2ED8F7@getmailspring.com/1?redirect=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAADMCDO7TZE6DZYSQAI3LG3SSLEZBANCNFSM4TRJ75RQ&recipient=cmVwbHkrQUFETUNET0ZNU0RMUUtSWEtCU1g2QU41MkFDSkJFVkJOSEhDWUlHRklBQHJlcGx5LmdpdGh1Yi5jb20%3D).
This is still an issue with latest update...
This issue has gotten worse, PetTracker removes almost all menu entries.
Without PetTracker:
With PetTracker:
Running Software (issues missing this information will be deleted):
Server patch: 9.0.1
Have you read the changelog? (please don't waste our time) Always
Describe the bug The addon is interfering with other addons that add buttons on the map, as seen in the screenshots below
Screenshots With Pet Tracker loaded, when I mouse over both these buttons it shows the same thing which is anyway wrong on both:
![image](https://user-images.githubusercontent.com/6321337/98748805-1aca6a00-23c3-11eb-86b3-5327892070c6.png)
Also I've made a gif here https://gfycat.com/prestigiousfreeegret
Now, the same 2 buttons if I disable Pet Tracker:
![image](https://user-images.githubusercontent.com/6321337/98748877-3e8db000-23c3-11eb-8b61-c53fd8cf8b66.png)
Note how for the right button, with Pet Tracker enabled, it was completely hiding the RareScanner section; also wtih Pet Tracker enableed, for the tooltip on the left side (one from Handy Notes: Battle for Azeroth) it's completely replacing the tooltip and instead of showing the real addon tooltip, it duplicates the one from the right button.
Error Logs No lua errors are shown at all.