search

Jaliborc / PetTracker

Tracks pets, alerts for upgrades and helps you in pet battles.
49 stars 26 forks source link

Optionally quit wild battles if there are no rare upgrades to be found #276

Open viridis opened 2 years ago

viridis commented 2 years ago

Existing Prompt for Forfeit functionality adds a popup if PetTracker does not sense an upgrade while entering a wild battle.

While trying to get every BattlePet to Rare without spending an infinite amount of stones on them, I would have liked a functionality that allows me to leave the combat if PetTracker senses there are no Rare pets in the wild pet pool.

This PR would add a checkbox on the interface image

And this checkbox would add the functionality that even if there are upgrades in the current wild battle, it still adds a popup if that upgrade is not a Rare upgrade image

I only added English localization. I went through a few files and it seemed like not everything is up to date with the English version, so I'm assuming there is a fallback anyway. I hope this is alright.

Jaliborc commented 2 years ago

Sounds very reasonable, and code looks good. I'm gonna merge this, but turnt the option into a dropdown of 3 modes I think (dont forfeit, forfeit, forfeit on non rare)

Jaliborc commented 2 years ago

And optimize the rare upgrade detection